Remove @firebase/app-types-exp #4461

Feiyang1 · 2021-02-11T20:25:06Z

No description provided.

changeset-bot · 2021-02-11T20:25:09Z

⚠️ No Changeset found

Latest commit: cde5290

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2021-02-11T21:45:46Z

Changeset File Check ✅

No modified packages are missing from the changeset file.
No changeset formatting errors detected.

google-oss-bot · 2021-02-11T22:09:13Z

Binary Size Report

Affected SDKs

`@firebase/app`

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
browser	11.2 kB	10.8 kB	-353 B (-3.2%)
esm2017	9.58 kB	9.57 kB	-12 B (-0.1%)
lite	9.25 kB	8.88 kB	-372 B (-4.0%)
lite-esm2017	7.88 kB	7.87 kB	-12 B (-0.2%)
main	10.9 kB	10.6 kB	-360 B (-3.3%)
module	11.2 kB	10.8 kB	-353 B (-3.2%)
react-native	10.6 kB	10.3 kB	-360 B (-3.4%)

@firebase/database

Type Base (c0a1f6b) Head (56031c1) Diff

browser 277 kB 277 kB +61 B (+0.0%)

esm2017 245 kB 245 kB +270 B (+0.1%)

main 280 kB 280 kB +56 B (+0.0%)

module 277 kB 277 kB +61 B (+0.0%)
@firebase/database-exp

Type Base (c0a1f6b) Head (56031c1) Diff

browser 278 kB 278 kB +61 B (+0.0%)

esm2017 242 kB 243 kB +270 B (+0.1%)

main 280 kB 280 kB +56 B (+0.0%)

module 278 kB 278 kB +61 B (+0.0%)

`@firebase/firestore-exp`

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
browser	199 kB	199 kB	+116 B (+0.1%)
main	505 kB	505 kB	+152 B (+0.0%)
module	199 kB	199 kB	+116 B (+0.1%)
react-native	200 kB	200 kB	+116 B (+0.1%)

`@firebase/firestore-lite`

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
browser	64.8 kB	64.9 kB	+96 B (+0.1%)
main	143 kB	144 kB	+152 B (+0.1%)
module	64.8 kB	64.9 kB	+96 B (+0.1%)
react-native	65.0 kB	65.1 kB	+96 B (+0.1%)

`firebase`

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
firebase-app.js	20.2 kB	19.9 kB	-276 B (-1.4%)
firebase-database.js	194 kB	193 kB	-791 B (-0.4%)
firebase-performance-standalone.es2017.js	71.9 kB	71.9 kB	-10 B (-0.0%)
firebase-performance-standalone.js	48.3 kB	48.0 kB	-271 B (-0.6%)
firebase.js	855 kB	854 kB	-1.07 kB (-0.1%)

Test Logs

Base (c0a1f6bf): https://github.com/firebase/firebase-js-sdk/actions/runs/558976164
Head (56031c1b): https://github.com/firebase/firebase-js-sdk/actions/runs/573617260

google-oss-bot · 2021-02-11T22:11:54Z

Size Analysis Report

Affected Products

@firebase/analytics-exp
- getAnalytics
  Size Table
  Type Base (c0a1f6b) Head (56031c1) Diff
  size
  9.01 kB
  9.04 kB
  +30 B (+0.3%)
  size-with-ext-deps
  26.5 kB
  26.6 kB
  +30 B (+0.1%)
- isSupported
  Size Table
  Type Base (c0a1f6b) Head (56031c1) Diff
  size
  9.07 kB
  9.10 kB
  +30 B (+0.3%)
  size-with-ext-deps
  26.6 kB
  26.6 kB
  +30 B (+0.1%)
- logEvent
  Size Table
  Type Base (c0a1f6b) Head (56031c1) Diff
  size
  8.93 kB
  8.96 kB
  +30 B (+0.3%)
  size-with-ext-deps
  26.5 kB
  26.5 kB
  +30 B (+0.1%)
- setAnalyticsCollectionEnabled
  Size Table
  Type Base (c0a1f6b) Head (56031c1) Diff
  size
  9.08 kB
  9.11 kB
  +30 B (+0.3%)
  size-with-ext-deps
  26.6 kB
  26.7 kB
  +30 B (+0.1%)
- setCurrentScreen
  Size Table
  Type Base (c0a1f6b) Head (56031c1) Diff
  size
  9.17 kB
  9.20 kB
  +30 B (+0.3%)
  size-with-ext-deps
  26.7 kB
  26.7 kB
  +30 B (+0.1%)
- setUserId
  Size Table
  Type Base (c0a1f6b) Head (56031c1) Diff
  size
  9.15 kB
  9.18 kB
  +30 B (+0.3%)
  size-with-ext-deps
  26.7 kB
  26.7 kB
  +30 B (+0.1%)
- setUserProperties
  Size Table
  Type Base (c0a1f6b) Head (56031c1) Diff
  size
  9.23 kB
  9.26 kB
  +30 B (+0.3%)
  size-with-ext-deps
  26.8 kB
  26.8 kB
  +30 B (+0.1%)
- settings
  Size Table
  Type Base (c0a1f6b) Head (56031c1) Diff
  size
  9.05 kB
  9.08 kB
  +30 B (+0.3%)
  size-with-ext-deps
  26.6 kB
  26.6 kB
  +30 B (+0.1%)

`@firebase/app-exp`

`_addComponent`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_addOrOverwriteComponent`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_clearComponents`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_getProvider`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_registerComponent`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_removeServiceInstance`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`deleteApp`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`getApp`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`getApps`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

initializeApp
Size Table
Type Base (c0a1f6b) Head (56031c1) Diff
size
3.96 kB
4.08 kB
+115 B (+2.9%)
size-with-ext-deps
9.24 kB
9.36 kB
+115 B (+1.2%)
Dependency Table
Type Base (c0a1f6b) Head (56031c1) Diff
classes
FirebaseAppImpl PlatformLoggerService
FirebaseAppImpl PlatformLoggerServiceImpl
+ PlatformLoggerServiceImpl - PlatformLoggerService

`onLog`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`registerVersion`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`setLogLevel`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`SDK_VERSION`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_DEFAULT_ENTRY_NAME`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_apps`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

`_components`

Dependency Table

Type	Base (`c0a1f6b`)	Head (`56031c1`)	Diff
classes	PlatformLoggerService	PlatformLoggerServiceImpl	+ PlatformLoggerServiceImpl - PlatformLoggerService

@firebase/auth-exp
- getAuth
  Size Table
  Type Base (c0a1f6b) Head (56031c1) Diff
  size
  55.5 kB
  55.7 kB
  +154 B (+0.3%)
  size-with-ext-deps
  66.4 kB
  66.6 kB
  +156 B (+0.2%)
- initializeAuth
  Size Table
  Type Base (c0a1f6b) Head (56031c1) Diff
  size
  28.3 kB
  28.4 kB
  +84 B (+0.3%)
  size-with-ext-deps
  39.0 kB
  39.1 kB
  +85 B (+0.2%)
- debugErrorMap
  Size Table
  Type Base (c0a1f6b) Head (56031c1) Diff
  size
  38.7 kB
  38.8 kB
  +69 B (+0.2%)
  size-with-ext-deps
  49.4 kB
  49.5 kB
  +69 B (+0.1%)

Test Logs

hsubox76

I think the changeset warning means you have to remove it from

firebase-js-sdk/.changeset/config.json

Line 17 in c0a1f6b

"@firebase/app-types-exp",

packages-exp/app-compat/src/public-types.ts

common/api-review/app-exp.api.md

hsubox76

LG, just need to fix database deps issue to address CI failure.

hsubox76 · 2021-02-16T18:01:48Z

packages/database/src/core/RepoManager.ts

@@ -16,7 +16,7 @@
 */

 import { FirebaseApp } from '@firebase/app-types';
-import { FirebaseApp as FirebaseAppExp } from '@firebase/app-types-exp';
+import { FirebaseApp as FirebaseAppExp } from '@firebase/app-exp';


I guess this should be added to database's deps (according to the failing check)

Feiyang1 added 17 commits February 10, 2021 15:40

remove app-types

02ef8e4

fix installations imports

c346561

fix perf imports

3105d7f

fix analytics imports

4b8177a

fix auth imports

c4c32f1

fix imports for functions

5ae2f92

fix app-compat imports

bfc5b34

fix auth-compat imports

655fc5d

fix functions-compat imports

f81a2b2

fix installations-compat imports

64a8cee

fix messaging-exp imports

1bf1257

fix remote-config-exp imports

d4782f2

fix remote-config-compat imports

6ad39d5

fix firestore imports

85334ce

fix storage imports

efd1396

remove reference to app-types-exp

9a3cc26

fix database imports

c8ac357

Feiyang1 requested review from avolkovi, hiranya911, hsubox76, jsdt, sam-gc, schmidt-sebastian and yuchenshi as code owners February 11, 2021 20:25

Feiyang1 assigned hsubox76 Feb 11, 2021

hsubox76 reviewed Feb 11, 2021

View reviewed changes

packages-exp/app-compat/src/public-types.ts Outdated Show resolved Hide resolved

common/api-review/app-exp.api.md Outdated Show resolved Hide resolved

common/api-review/app-exp.api.md Outdated Show resolved Hide resolved

address comments

06beb2c

Feiyang1 mentioned this pull request Feb 12, 2021

Implement analytics-compat package #4460

Merged

hsubox76 approved these changes Feb 16, 2021

View reviewed changes

Feiyang1 added 2 commits February 16, 2021 17:10

fix lint error

c689795

fix exp build

cde5290

Feiyang1 merged commit b3f2eef into master Feb 17, 2021

Feiyang1 deleted the fei-remove-types branch February 17, 2021 05:03

firebase locked and limited conversation to collaborators Mar 20, 2021

Remove @firebase/app-types-exp #4461

Remove @firebase/app-types-exp #4461

Uh oh!

Conversation

Feiyang1 commented Feb 11, 2021

Uh oh!

changeset-bot bot commented Feb 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

github-actions bot commented Feb 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changeset File Check ✅

Uh oh!

google-oss-bot commented Feb 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Binary Size Report

Affected SDKs

@firebase/app

@firebase/database

@firebase/database-exp

@firebase/firestore-exp

@firebase/firestore-lite

firebase

Test Logs

Uh oh!

google-oss-bot commented Feb 11, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Size Analysis Report

Affected Products

@firebase/analytics-exp

getAnalytics

isSupported

logEvent

setAnalyticsCollectionEnabled

setCurrentScreen

setUserId

setUserProperties

settings

@firebase/app-exp

_addComponent

_addOrOverwriteComponent

_clearComponents

_getProvider

_registerComponent

_removeServiceInstance

deleteApp

getApp

getApps

initializeApp

onLog

registerVersion

setLogLevel

SDK_VERSION

_DEFAULT_ENTRY_NAME

_apps

_components

@firebase/auth-exp

getAuth

initializeAuth

debugErrorMap

Test Logs

Uh oh!

hsubox76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hsubox76 left a comment

Choose a reason for hiding this comment

Uh oh!

hsubox76 Feb 16, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

changeset-bot bot commented Feb 11, 2021 •

edited

Loading

github-actions bot commented Feb 11, 2021 •

edited

Loading

google-oss-bot commented Feb 11, 2021 •

edited

Loading

`@firebase/app`

`@firebase/database`

`@firebase/database-exp`

`@firebase/firestore-exp`

`@firebase/firestore-lite`

`firebase`

google-oss-bot commented Feb 11, 2021 •

edited

Loading

`@firebase/analytics-exp`

`getAnalytics`

`isSupported`

`logEvent`

`setAnalyticsCollectionEnabled`

`setCurrentScreen`

`setUserId`

`setUserProperties`

`settings`

`@firebase/app-exp`

`_addComponent`

`_addOrOverwriteComponent`

`_clearComponents`

`_getProvider`

`_registerComponent`

`_removeServiceInstance`

`deleteApp`

`getApp`

`getApps`

`initializeApp`

`onLog`

`registerVersion`

`setLogLevel`

`SDK_VERSION`

`_DEFAULT_ENTRY_NAME`

`_apps`

`_components`

`@firebase/auth-exp`

`getAuth`

`initializeAuth`

`debugErrorMap`