Skip to content

Fix changeset checker logic #4411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2021
Merged

Fix changeset checker logic #4411

merged 1 commit into from
Feb 3, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Feb 3, 2021

Blocking flag should only be set if firebase bump is mismatched or missing.

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2021

⚠️ No Changeset found

Latest commit: 1f83c77

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

No changes between base commit (09e8249) and head commit (2a40fdc).

Test Logs

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (09e8249) and head commit (2a40fdc).

@hsubox76 hsubox76 merged commit 0eeefe2 into master Feb 3, 2021
@hsubox76 hsubox76 deleted the ch-fix-checker branch February 3, 2021 23:18
@firebase firebase locked and limited conversation to collaborators Mar 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants