Skip to content

Commit 0eeefe2

Browse files
authored
Fix changeset checker change (#4411)
1 parent 09e8249 commit 0eeefe2

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

scripts/check_changeset.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ function getHighestBump(changesetPackages: Record<string, string>) {
4040
let highestBump = bumpRank.patch;
4141
let highestBumpText = 'patch';
4242
let bumpPackage = '';
43-
for (const pkgName of Object.keys(changesetPackages)) {
43+
for (const pkgName of Object.keys(changesetPackages)) {
4444
if (
4545
pkgName !== 'firebase' &&
4646
bumpRank[changesetPackages[pkgName]] > highestBump
@@ -177,13 +177,14 @@ async function main() {
177177
`- Package ${bumpPackage} has a ${bumpText} bump which requires an ` +
178178
`additional line to bump the main "firebase" package to ${bumpText}.`
179179
);
180+
console.log(`::set-output name=BLOCKING_FAILURE::true`);
180181
} else if (bumpRank[changesetPackages['firebase']] < highestBump) {
181182
errors.push(
182183
`- Package ${bumpPackage} has a ${bumpText} bump. ` +
183184
`Increase the bump for the main "firebase" package to ${bumpText}.`
184185
);
186+
console.log(`::set-output name=BLOCKING_FAILURE::true`);
185187
}
186-
console.log(`::set-output name=BLOCKING_FAILURE::true`);
187188
}
188189
}
189190
} catch (e) {

0 commit comments

Comments
 (0)