Add initial bare-bones Cordova support / popup redirect #4379
Conversation
|
| export { browserLocalPersistence } from './src/platform_browser/persistence/local_storage'; | ||
| export { browserSessionPersistence } from './src/platform_browser/persistence/session_storage'; | ||
|
|
||
| export { cordovaPopupRedirectResolver } from './src/platform_cordova/popup_redirect'; |
There was a problem hiding this comment.
Yes. It can be used independently (if you use initializeAuth() for example instead of getAuth())
packages-exp/auth-exp/src/platform_cordova/popup_redirect.test.ts
Outdated
Show resolved
Hide resolved
packages-exp/auth-exp/src/platform_cordova/popup_redirect.test.ts
Outdated
Show resolved
Hide resolved
| }); | ||
| }); | ||
|
|
||
| function setExpectedPluginsButMissing(missingPlugins: string[]): void { |
There was a problem hiding this comment.
IMO it's probably easier to just have this function mock the whole thing (with all plugins), and then write things like delete window.universalLinks.subscribe in individual tests. It's more straightforward and don't need the awkward object traversing below.
There was a problem hiding this comment.
Done. Still have to do a bit of a dance because the package doesn't mark those as optional. Still cleaner 👍
packages-exp/auth-exp/src/platform_cordova/popup_redirect.test.ts
Outdated
Show resolved
Hide resolved
sam-gc
force-pushed
the
samgho/platform-cordova
branch
from
983c226 to
e228278
Compare
No description provided.