Skip to content

Commit 983c226

Browse files
committed
Formatting
1 parent 29a9bb6 commit 983c226

File tree

7 files changed

+70
-36
lines changed

7 files changed

+70
-36
lines changed

packages-exp/auth-exp/index.cordova.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,19 +34,19 @@ import { ClientPlatform } from './src/core/util/version';
3434
export * from './src';
3535

3636
// Cordova also supports indexedDB / browserSession / browserLocal
37-
export {indexedDBLocalPersistence} from './src/platform_browser/persistence/indexed_db';
38-
export {browserLocalPersistence} from './src/platform_browser/persistence/local_storage';
39-
export {browserSessionPersistence} from './src/platform_browser/persistence/session_storage';
37+
export { indexedDBLocalPersistence } from './src/platform_browser/persistence/indexed_db';
38+
export { browserLocalPersistence } from './src/platform_browser/persistence/local_storage';
39+
export { browserSessionPersistence } from './src/platform_browser/persistence/session_storage';
4040

41-
export {cordovaPopupRedirectResolver} from './src/platform_cordova/popup_redirect';
42-
export {signInWithRedirect} from './src/platform_cordova/strategies/redirect';
41+
export { cordovaPopupRedirectResolver } from './src/platform_cordova/popup_redirect';
42+
export { signInWithRedirect } from './src/platform_cordova/strategies/redirect';
4343

44-
import {cordovaPopupRedirectResolver} from './src/platform_cordova/popup_redirect';
44+
import { cordovaPopupRedirectResolver } from './src/platform_cordova/popup_redirect';
4545

4646
export function getAuth(app: FirebaseApp): Auth {
4747
return initializeAuth(app, {
4848
persistence: indexedDBLocalPersistence,
49-
popupRedirectResolver: cordovaPopupRedirectResolver,
49+
popupRedirectResolver: cordovaPopupRedirectResolver
5050
});
5151
}
5252

packages-exp/auth-exp/src/core/errors.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -405,7 +405,7 @@ export interface AuthErrorParams extends GenericAuthErrorParams {
405405
[AuthErrorCode.INVALID_CORDOVA_CONFIGURATION]: {
406406
appName: AppName;
407407
missingPlugin?: string;
408-
}
408+
};
409409
}
410410

411411
export const _DEFAULT_AUTH_ERROR_FACTORY = new ErrorFactory<

packages-exp/auth-exp/src/core/util/resolver.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,4 +40,4 @@ export function _withDefaultResolver(
4040
_assert(auth._popupRedirectResolver, auth, AuthErrorCode.ARGUMENT_ERROR);
4141

4242
return auth._popupRedirectResolver;
43-
}
43+
}

packages-exp/auth-exp/src/platform_cordova/plugins.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,4 +34,4 @@ declare namespace universalLinks {
3434

3535
declare namespace BuildInfo {
3636
const packageName: string;
37-
}
37+
}

packages-exp/auth-exp/src/platform_cordova/popup_redirect.test.ts

Lines changed: 42 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -34,41 +34,64 @@ describe('platform_cordova/popup_redirect', () => {
3434

3535
beforeEach(async () => {
3636
auth = await testAuth();
37-
resolver = new (cordovaPopupRedirectResolver as SingletonInstantiator<
38-
PopupRedirectResolver
39-
>)();
37+
resolver = new (cordovaPopupRedirectResolver as SingletonInstantiator<PopupRedirectResolver>)();
4038
});
4139

4240
describe('_openRedirect plugin checks', () => {
4341
// TODO: Rest of the tests go here
4442
it('does not reject if all plugins installed', () => {
4543
setExpectedPluginsButMissing([]);
46-
expect(() => resolver._openRedirect(auth, new GoogleAuthProvider(), AuthEventType.SIGN_IN_VIA_REDIRECT))
47-
.not.to.throw;
44+
expect(() =>
45+
resolver._openRedirect(
46+
auth,
47+
new GoogleAuthProvider(),
48+
AuthEventType.SIGN_IN_VIA_REDIRECT
49+
)
50+
).not.to.throw;
4851
});
4952

5053
it('rejects if universal links is missing', () => {
5154
setExpectedPluginsButMissing(['universalLinks.subscribe']);
52-
expect(() => resolver._openRedirect(auth, new GoogleAuthProvider(), AuthEventType.SIGN_IN_VIA_REDIRECT))
53-
.to.throw(FirebaseError, 'auth/invalid-cordova-configuration');
55+
expect(() =>
56+
resolver._openRedirect(
57+
auth,
58+
new GoogleAuthProvider(),
59+
AuthEventType.SIGN_IN_VIA_REDIRECT
60+
)
61+
).to.throw(FirebaseError, 'auth/invalid-cordova-configuration');
5462
});
5563

5664
it('rejects if build info is missing', () => {
5765
setExpectedPluginsButMissing(['BuildInfo.packageName']);
58-
expect(() => resolver._openRedirect(auth, new GoogleAuthProvider(), AuthEventType.SIGN_IN_VIA_REDIRECT))
59-
.to.throw(FirebaseError, 'auth/invalid-cordova-configuration');
66+
expect(() =>
67+
resolver._openRedirect(
68+
auth,
69+
new GoogleAuthProvider(),
70+
AuthEventType.SIGN_IN_VIA_REDIRECT
71+
)
72+
).to.throw(FirebaseError, 'auth/invalid-cordova-configuration');
6073
});
6174

6275
it('rejects if browsertab openUrl', () => {
6376
setExpectedPluginsButMissing(['cordova.plugins.browsertab.openUrl']);
64-
expect(() => resolver._openRedirect(auth, new GoogleAuthProvider(), AuthEventType.SIGN_IN_VIA_REDIRECT))
65-
.to.throw(FirebaseError, 'auth/invalid-cordova-configuration');
77+
expect(() =>
78+
resolver._openRedirect(
79+
auth,
80+
new GoogleAuthProvider(),
81+
AuthEventType.SIGN_IN_VIA_REDIRECT
82+
)
83+
).to.throw(FirebaseError, 'auth/invalid-cordova-configuration');
6684
});
6785

6886
it('rejects if InAppBrowser is missing', () => {
6987
setExpectedPluginsButMissing(['cordova.InAppBrowser.open']);
70-
expect(() => resolver._openRedirect(auth, new GoogleAuthProvider(), AuthEventType.SIGN_IN_VIA_REDIRECT))
71-
.to.throw(FirebaseError, 'auth/invalid-cordova-configuration');
88+
expect(() =>
89+
resolver._openRedirect(
90+
auth,
91+
new GoogleAuthProvider(),
92+
AuthEventType.SIGN_IN_VIA_REDIRECT
93+
)
94+
).to.throw(FirebaseError, 'auth/invalid-cordova-configuration');
7295
});
7396
});
7497
});
@@ -81,18 +104,18 @@ function setExpectedPluginsButMissing(missingPlugins: string[]): void {
81104
plugins: {
82105
browsertab: {
83106
isAvailable: () => {},
84-
openUrl: () => {},
107+
openUrl: () => {}
85108
}
86109
},
87110
InAppBrowser: {
88-
open: () => {},
89-
},
111+
open: () => {}
112+
}
90113
};
91114
win.universalLinks = {
92-
subscribe: () => {},
115+
subscribe: () => {}
93116
};
94117
win.BuildInfo = {
95-
packageName: 'com.name.package',
118+
packageName: 'com.name.package'
96119
};
97120

98121
for (const missing of missingPlugins) {
@@ -105,4 +128,4 @@ function setExpectedPluginsButMissing(missingPlugins: string[]): void {
105128
}
106129
delete obj[last];
107130
}
108-
}
131+
}

packages-exp/auth-exp/src/platform_cordova/popup_redirect.ts

Lines changed: 17 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,11 @@ import './plugins';
1919
import * as externs from '@firebase/auth-types-exp';
2020
import { browserSessionPersistence } from '../platform_browser/persistence/session_storage';
2121
import { Auth } from '../model/auth';
22-
import { AuthEventType, EventManager, PopupRedirectResolver } from '../model/popup_redirect';
22+
import {
23+
AuthEventType,
24+
EventManager,
25+
PopupRedirectResolver
26+
} from '../model/popup_redirect';
2327
import { AuthPopup } from '../platform_browser/util/popup';
2428
import { _fail } from '../core/util/assert';
2529
import { AuthErrorCode } from '../core/errors';
@@ -31,16 +35,23 @@ class CordovaPopupRedirectResolver implements PopupRedirectResolver {
3135
_openPopup(auth: Auth): Promise<AuthPopup> {
3236
_fail(auth, AuthErrorCode.OPERATION_NOT_SUPPORTED);
3337
}
34-
_openRedirect(auth: Auth, _provider: externs.AuthProvider, _authType: AuthEventType, _eventId?: string): Promise<never> {
38+
_openRedirect(
39+
auth: Auth,
40+
_provider: externs.AuthProvider,
41+
_authType: AuthEventType,
42+
_eventId?: string
43+
): Promise<never> {
3544
checkCordovaConfiguration(auth);
3645
return new Promise(() => {});
3746
}
38-
_isIframeWebStorageSupported(_auth: Auth, _cb: (support: boolean) => unknown): void {
47+
_isIframeWebStorageSupported(
48+
_auth: Auth,
49+
_cb: (support: boolean) => unknown
50+
): void {
3951
throw new Error('Method not implemented.');
4052
}
4153
readonly _redirectPersistence = browserSessionPersistence;
4254
_completeRedirectFn: () => Promise<null> = async () => null;
43-
4455
}
4556

4657
function checkCordovaConfiguration(auth: Auth): void {
@@ -51,7 +62,7 @@ function checkCordovaConfiguration(auth: Auth): void {
5162
// https://www.npmjs.com/package/cordova-universal-links-plugin-fix
5263
if (typeof window?.universalLinks?.subscribe !== 'function') {
5364
_fail(auth, AuthErrorCode.INVALID_CORDOVA_CONFIGURATION, {
54-
missingPlugin: 'cordova-universal-links-plugin-fix',
65+
missingPlugin: 'cordova-universal-links-plugin-fix'
5566
});
5667
}
5768

@@ -83,4 +94,4 @@ function checkCordovaConfiguration(auth: Auth): void {
8394
*
8495
* @public
8596
*/
86-
export const cordovaPopupRedirectResolver: externs.PopupRedirectResolver = CordovaPopupRedirectResolver;
97+
export const cordovaPopupRedirectResolver: externs.PopupRedirectResolver = CordovaPopupRedirectResolver;

packages-exp/auth-exp/src/platform_cordova/strategies/redirect.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ export async function signInWithRedirect(
4343
provider,
4444
AuthEventType.SIGN_IN_VIA_REDIRECT
4545
);
46-
}
46+
}

0 commit comments

Comments
 (0)