Skip to content

Clean up source location #4183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Clean up source location #4183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f97d799
Clean up source location
schmidt-sebastian Dec 8, 2020
9195a40
Update Scripts
schmidt-sebastian Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions common/api-review/firestore-exp.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ import { _FirebaseService } from '@firebase/app-types-exp';
import { LogLevelString as LogLevel } from '@firebase/logger';
import { Provider } from '@firebase/component';
import { SetOptions as SetOptions_2 } from '@firebase/firestore-types';
import { SnapshotMetadata as SnapshotMetadata_2 } from '@firebase/firestore-types';

// @public
export function addDoc<T>(reference: CollectionReference<T>, data: T): Promise<DocumentReference<T>>;
Expand Down Expand Up @@ -440,11 +439,11 @@ export interface SnapshotListenOptions {
}

// @public
export class SnapshotMetadata implements SnapshotMetadata_2 {
export class SnapshotMetadata {
constructor(hasPendingWrites: boolean, fromCache: boolean);
readonly fromCache: boolean;
readonly hasPendingWrites: boolean;
isEqual(other: SnapshotMetadata_2): boolean;
isEqual(other: SnapshotMetadata): boolean;
}

// @public
Expand Down
4 changes: 3 additions & 1 deletion common/api-review/firestore-lite.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,10 @@ export abstract class FieldValue {
abstract _toFieldTransform(context: ParseContext): FieldTransform | null;
}

// Warning: (ae-forgotten-export) The symbol "FirestoreService" needs to be exported by the entry point index.d.ts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how to interpret this comment. Is this a TODO? Is this suppressing a warning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an artifact from our API generation pipeline, which produces these auto-generated files. My goal is to fix this problem in the current sprint.

//
// @public
export class FirebaseFirestore implements _FirebaseService {
export class FirebaseFirestore implements FirestoreService {
constructor(databaseIdOrApp: DatabaseId | FirebaseApp, authProvider: Provider<FirebaseAuthInternalName>);
get app(): FirebaseApp;
// Warning: (ae-forgotten-export) The symbol "CredentialsProvider" needs to be exported by the entry point index.d.ts
Expand Down
19 changes: 0 additions & 19 deletions packages/firestore/.idea/runConfigurations/firestore_exp_Tests__Emulator__.xml
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions .../firestore/.idea/runConfigurations/firestore_exp_Tests__Emulator_w__Mock_Persistence_.xml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/firestore/.idea/runConfigurations/firestore_lite_Tests__Emulator_.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading