Clean up source location #4183
Clean up source location #4183
Conversation
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
|
schmidt-sebastian
force-pushed
the
mrschmidt/movefiles
branch
from
74a4b0e to
dc0d3a4
Compare
schmidt-sebastian
force-pushed
the
mrschmidt/movefiles
branch
from
dc0d3a4 to
f97d799
Compare
| @@ -168,8 +168,10 @@ export abstract class FieldValue { | |||
| abstract _toFieldTransform(context: ParseContext): FieldTransform | null; | |||
| } | |||
|
|
|||
| // Warning: (ae-forgotten-export) The symbol "FirestoreService" needs to be exported by the entry point index.d.ts | |||
There was a problem hiding this comment.
I don't know how to interpret this comment. Is this a TODO? Is this suppressing a warning?
There was a problem hiding this comment.
This is an artifact from our API generation pipeline, which produces these auto-generated files. My goal is to fix this problem in the current sprint.
| @@ -15,40 +15,41 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| // eslint-disable-next-line import/no-extraneous-dependencies | |||
There was a problem hiding this comment.
Is it worth separating this group of imports from the rest and adding a comment about why this is necessary?
There was a problem hiding this comment.
We are now using eslint to sort our imports (possible since we no longer have cycled dependencies). With that, we lost all control over formatting and empty lines.
This commit cleans up some of the code structure around firestore-exp/firestore-lite.
The changes are:
expsupport from the Karma runner.dependencies.jsonfiles that were used during development. Updated the build rules to instead create this these in a temporary location.TimestampandGeoPointto src/lite and added some export-only files to src/exp. The goal is to have a clear dependency chain where /api can only depend on /exp and /exp can only depend on /lite (the next step would be to move theUserDataReadertosrc/lite).