Skip to content

Small set of random fixes for firestore-exp types #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 24, 2020
Merged

Small set of random fixes for firestore-exp types #4106

merged 3 commits into from
Nov 24, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

This is part of #4095 and meant to reduce diff

@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2020 •
edited
Loading

⚠️ No Changeset found

Latest commit: 695db64

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@rafikhan
Copy link
Contributor

LGTM

rafikhan
rafikhan approved these changes Nov 24, 2020
View reviewed changes
Copy link
Contributor

@rafikhan rafikhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (be56cd8) and head commit (b030531).

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit 6358fd0 into master Nov 24, 2020
@firebase firebase locked and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rafikhan rafikhan rafikhan approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @rafikhan @google-oss-bot