Skip to content

API Extractor support for Firestore Exp and Lite #4095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Nov 25, 2020
Merged

API Extractor support for Firestore Exp and Lite #4095

merged 32 commits into from
Nov 25, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

This builds on top of the new script to add support for API Extractor to Firestore.

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2020 •
edited
Loading

⚠️ No Changeset found

Latest commit: decc324

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@schmidt-sebastian schmidt-sebastian mentioned this pull request Nov 20, 2020
Merged
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 20, 2020 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (ddb7993) and head commit (3dcab73).

Test Logs

Feiyang1
Feiyang1 approved these changes Nov 20, 2020
View reviewed changes
Copy link
Member

@Feiyang1 Feiyang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question.

packages/firestore/exp/api-extractor.json
},
"tsdocMessageReporting": {
"tsdoc-undefined-tag": {
"logLevel": "none"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you not want to get warned about APIs that don't have documentation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hides the warning for @hideconstructor.

schmidt-sebastian
schmidt-sebastian commented Nov 24, 2020
View reviewed changes
Copy link
Contributor Author

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I rebased this now so it has (almost) no cleanup/code changes anymore.

packages/firestore/exp/api-extractor.json
},
"tsdocMessageReporting": {
"tsdoc-undefined-tag": {
"logLevel": "none"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hides the warning for @hideconstructor.

@schmidt-sebastian schmidt-sebastian changed the base branch from mrschmidt/standalonescript to master November 25, 2020 16:28
@schmidt-sebastian schmidt-sebastian merged commit fe9524c into master Nov 25, 2020
@firebase firebase locked and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @Feiyang1