Skip to content

bundle the package in order to get the size for an entry point #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2020
Merged

bundle the package in order to get the size for an entry point #4094

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions scripts/size_report/report_binary_size.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
* limitations under the License.
*/

import { resolve } from 'path';
import { resolve as pathResolve } from 'path';
import * as fs from 'fs';
import { execSync } from 'child_process';
import * as terser from 'terser';
Expand All @@ -25,6 +25,8 @@ import {
RequestBody,
RequestEndpoint
} from './size_report_helper';
import * as rollup from 'rollup';
import commonjs from '@rollup/plugin-commonjs';

interface Report {
sdk: string;
Expand All @@ -38,7 +40,7 @@ interface BinarySizeRequestBody extends RequestBody {
// CDN scripts
function generateReportForCDNScripts(): Report[] {
const reports = [];
const firebaseRoot = resolve(__dirname, '../../packages/firebase');
const firebaseRoot = pathResolve(__dirname, '../../packages/firebase');
const pkgJson = require(`${firebaseRoot}/package.json`);

const special_files = [
Expand Down Expand Up @@ -103,8 +105,16 @@ async function generateReportForNPMPackages(): Promise<Report[]> {

for (const field of fields) {
if (packageJson[field]) {
const filePath = `${path}/${packageJson[field]}`;
const rawCode = fs.readFileSync(filePath, 'utf-8');
const filePath = pathResolve(path, packageJson[field]);
// Need to create a bundle and get the size of the bundle instead of reading the size of the file directly.
// It is because some packages might be split into multiple files in order to share code between entry points.
const bundle = await rollup.rollup({
input: filePath,
plugins: [commonjs()]
});

const { output } = await bundle.generate({ format: 'es' });
const rawCode = output[0].code;

// remove comments and whitespaces, then get size
const { code } = await terser.minify(rawCode, {
Expand All @@ -122,7 +132,6 @@ async function generateReportForNPMPackages(): Promise<Report[]> {

resolve();
});

taskPromises.push(promise);
}
}
Expand Down