Skip to content

bundle the package in order to get the size for an entry point #4094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

Feiyang1
Copy link
Member

A packages might be split into multiple files in order to share code between entry points. The shared code is extracted to a shared file that all entry points import.
As a result, an entry point file may not include all code and we need to make a bundle to get the actual size of the entry point.

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2020

⚠️ No Changeset found

Latest commit: f406c22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Feiyang1 Feiyang1 mentioned this pull request Nov 19, 2020
@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (9822e12) and head commit (2d5a660).

Test Logs

@Feiyang1 Feiyang1 merged commit b3ee391 into master Nov 19, 2020
@Feiyang1 Feiyang1 deleted the fei-health-metrics branch November 19, 2020 22:42
@firebase firebase locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants