Meet peer dependency of @firebase/auth-interop-types #4087
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yarn
insists that any peer dependencies of packages you depend upon yourself, must also be included in your own dependencies. If not it will print warnings.Currently the
@firebase/database
package depends upon@firebase/auth-interop-types
, which has a peer dependency on@firebase/app-types
. However@firebase/app-types
is set as a dev dependency rather than a regular one resulting in a warning when installing@firebase/database
or any package that depends upon it (since I know it's an internal package).This is quite annoying as projects that have a
firebase-admin
dependency get an unavoidable warning during installation (e.g. taskline) which can put users off.This has come up previously in regards to the
firebase
package (#1207 & #1794) and was fixed by @Feiyang1 in #1807. However,firebase-admin
is still facing this issue. It was reported in thefirebase-admin
repo (firebase/firebase-admin-node#973) but hasn't received any traction, possibly due to the fact the actual issue resides in this one.