Skip to content

Meet peer dependency of @firebase/auth-interop-types #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Meet peer dependency of @firebase/auth-interop-types #4087

wants to merge 1 commit into from

Conversation

strafe
Copy link

@strafe strafe commented Nov 18, 2020

yarn insists that any peer dependencies of packages you depend upon yourself, must also be included in your own dependencies. If not it will print warnings.

Currently the @firebase/database package depends upon @firebase/auth-interop-types, which has a peer dependency on @firebase/app-types. However @firebase/app-types is set as a dev dependency rather than a regular one resulting in a warning when installing @firebase/database or any package that depends upon it (since I know it's an internal package).

$ yarn add firebase-admin
yarn add v1.22.10
info No lockfile found.
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[3/4] 🔗  Linking dependencies...
warning "firebase-admin > @firebase/database > @firebase/[email protected]" has unmet peer dependency "@firebase/[email protected]".
[4/4] 🔨  Building fresh packages...

This is quite annoying as projects that have a firebase-admin dependency get an unavoidable warning during installation (e.g. taskline) which can put users off.


This has come up previously in regards to the firebase package (#1207 & #1794) and was fixed by @Feiyang1 in #1807. However, firebase-admin is still facing this issue. It was reported in the firebase-admin repo (firebase/firebase-admin-node#973) but hasn't received any traction, possibly due to the fact the actual issue resides in this one.

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2020

⚠️ No Changeset found

Latest commit: 853a0de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-cla
Copy link

google-cla bot commented Nov 18, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@strafe
Copy link
Author

strafe commented Nov 18, 2020

@googlebot I signed it!

@ryck
Copy link

ryck commented Feb 23, 2021

It would be nice to have this resolved, I hate warnings on my logs :)

@hsubox76
Copy link
Contributor

Fixing auth-interop-types here: #6940

@firebase firebase locked and limited conversation to collaborators Feb 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants