Skip to content

warnings when installing with yarn #1794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PutziSan opened this issue May 17, 2019 · 3 comments
Closed

warnings when installing with yarn #1794

PutziSan opened this issue May 17, 2019 · 3 comments

Comments

@PutziSan
Copy link

This is a duplicate of #1207, but there is no further reaction and the problem is definitely not fixed yet. The very first impression of firebase when you install it with yarn is a real WOW-experience (wall-of-warning-experience):

image

And please, the solution is not "just use npm". If you want to leave it as peerDependency, okay, it's your package. But could you explain to us why you decide to do this? Maybe it's a very good point and we can learn something.

Please also see the comment at the corresponding yarn-issue: yarnpkg/yarn#5347 (comment)

[REQUIRED] Describe your environment

  • Operating System version: win10, yarn-1.16.0
  • Firebase SDK version: [email protected]
  • Firebase Product: all

[REQUIRED] Describe the problem

When installing with yarn, warnings appear.

Steps to reproduce:

mkdir firebase-warning
cd firebase-warning
yarn add firebase
@google-oss-bot
Copy link
Contributor

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

@PutziSan PutziSan changed the title warnings warnings when installing with yarn May 17, 2019
@Feiyang1
Copy link
Member

Feiyang1 commented May 21, 2019

Thank you for bringing this issue to our attention, again!

This is definitely not a good user experience and we should fix it given the fact that yarn is really popular nowadays. I made a PR to address it - #1807

As to why we keep @firebase/app-type as a peer dependency - it's because @firebase/app is a peer dependency and @firebase/app-type should be the same one that @firebase/app depends on.

It makes sense for @firebase/{component} (e.g. @firebase/firestore, @firebase/auth) to peer depend on @firebase/app, otherwise if you install @firebase/{component} individually and each of the component depends on a different version of @firebase/app, you will run into incompatible firebase instances and other weird issues caused by it.

@Feiyang1
Copy link
Member

Closing this as 6.0.4 is out with the fix.

@firebase firebase locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants