-
Notifications
You must be signed in to change notification settings - Fork 924
warnings when installing with yarn #1794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight. |
Thank you for bringing this issue to our attention, again! This is definitely not a good user experience and we should fix it given the fact that yarn is really popular nowadays. I made a PR to address it - #1807 As to why we keep It makes sense for |
Closing this as 6.0.4 is out with the fix. |
This is a duplicate of #1207, but there is no further reaction and the problem is definitely not fixed yet. The very first impression of firebase when you install it with yarn is a real WOW-experience (wall-of-warning-experience):
And please, the solution is not "just use npm". If you want to leave it as peerDependency, okay, it's your package. But could you explain to us why you decide to do this? Maybe it's a very good point and we can learn something.
Please also see the comment at the corresponding yarn-issue: yarnpkg/yarn#5347 (comment)
[REQUIRED] Describe your environment
[REQUIRED] Describe the problem
When installing with yarn, warnings appear.
Steps to reproduce:
mkdir firebase-warning cd firebase-warning yarn add firebase
The text was updated successfully, but these errors were encountered: