-
Notifications
You must be signed in to change notification settings - Fork 926
Implement useEmulator for Firestore #3909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 3332d63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset File Check ✅No modified packages are missing from the changeset file. |
Binary Size ReportAffected SDKs
Test Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM. I think we should merge the two error checks that verify that the settings cannot be changed after instantiation.
Discussion
This PR is part of a group: #3904 #3906 #3909
Note: I did not feel comfortable adding this to
firestore-exp
because I couldn't quite understand the internals and it seems like we'll need to amend the API proposal to add something likeEmulatorSettings
since it looks like there is no longer a global settings object. Hoping @schmidt-sebastian can do that in a follow-up PR?Android implementation:
firebase/firebase-android-sdk#1802
This follows Proposal 2 at:
http://go/firebase-emulator-connection-api
Testing
API Changes