Skip to content

Commit 8939aec

Browse files
Remove undocumented getLogLevel (#3944)
1 parent ffef32e commit 8939aec

File tree

3 files changed

+21
-34
lines changed

3 files changed

+21
-34
lines changed

.changeset/great-rice-smash.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"firebase": major
3+
"@firebase/firestore": major
4+
---
5+
6+
Removed the undocumented `Firestore.logLevel` property.

packages/firestore/src/api/database.ts

+12-32
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ import {
111111
valueDescription,
112112
validateIsNotUsedTogether
113113
} from '../util/input_validation';
114-
import { getLogLevel, logError, LogLevel, setLogLevel } from '../util/log';
114+
import { logError, setLogLevel as setClientLogLevel } from '../util/log';
115115
import { AutoId } from '../util/misc';
116116
import { Deferred } from '../util/promise';
117117
import { FieldPath as ExternalFieldPath } from './field_path';
@@ -752,43 +752,23 @@ export class Firestore implements PublicFirestore, FirebaseService {
752752
return new WriteBatch(this);
753753
}
754754

755-
static get logLevel(): PublicLogLevel {
756-
switch (getLogLevel()) {
757-
case LogLevel.DEBUG:
758-
return 'debug';
759-
case LogLevel.ERROR:
760-
return 'error';
761-
case LogLevel.SILENT:
762-
return 'silent';
763-
case LogLevel.WARN:
764-
return 'warn';
765-
case LogLevel.INFO:
766-
return 'info';
767-
case LogLevel.VERBOSE:
768-
return 'verbose';
769-
default:
770-
// The default log level is error
771-
return 'error';
772-
}
773-
}
774-
775-
static setLogLevel(level: PublicLogLevel): void {
776-
validateExactNumberOfArgs('Firestore.setLogLevel', arguments, 1);
777-
validateStringEnum(
778-
'setLogLevel',
779-
['debug', 'error', 'silent', 'warn', 'info', 'verbose'],
780-
1,
781-
level
782-
);
783-
setLogLevel(level);
784-
}
785-
786755
// Visible for testing.
787756
_getSettings(): PublicSettings {
788757
return this._settings;
789758
}
790759
}
791760

761+
export function setLogLevel(level: PublicLogLevel): void {
762+
validateExactNumberOfArgs('Firestore.setLogLevel', arguments, 1);
763+
validateStringEnum(
764+
'setLogLevel',
765+
['debug', 'error', 'silent', 'warn', 'info', 'verbose'],
766+
1,
767+
level
768+
);
769+
setClientLogLevel(level);
770+
}
771+
792772
/**
793773
* A reference to a transaction.
794774
*/

packages/firestore/src/config.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ import {
2929
QueryDocumentSnapshot,
3030
QuerySnapshot,
3131
Transaction,
32-
WriteBatch
32+
WriteBatch,
33+
setLogLevel
3334
} from './api/database';
3435
import { Blob } from './api/blob';
3536
import { FieldPath } from './api/field_path';
@@ -52,7 +53,7 @@ const firestoreNamespace = {
5253
CollectionReference,
5354
FieldPath,
5455
FieldValue,
55-
setLogLevel: Firestore.setLogLevel,
56+
setLogLevel,
5657
CACHE_SIZE_UNLIMITED
5758
};
5859

0 commit comments

Comments
 (0)