Skip to content

Fix assertFails() logic of @firebase/rules-unit-testing #3676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 25, 2020
Merged

Fix assertFails() logic of @firebase/rules-unit-testing #3676

merged 3 commits into from
Aug 25, 2020

Conversation

mogaming217
Copy link
Contributor

fix #3671

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2020

🦋 Changeset is good to go

Latest commit: 1e2c181

We got this.

This PR includes changesets to release 1 package
Name Type
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@mogaming217
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@yuchenshi yuchenshi merged commit e749ab8 into firebase:master Aug 25, 2020
@yuchenshi
Copy link
Member

@mogaming217 Thank you and PR merged! This should go out with the next patch release soon.

@mogaming217 mogaming217 deleted the rules_unit_testing_fix_assertFails branch August 25, 2020 21:28
This was referenced Aug 25, 2020
@firebase firebase locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

assertFails() of rules-unit-testing is incorrect
4 participants