Fix assertFails() logic of @firebase/rules-unit-testing (#3676)

* Fix assertFails logic

* Create fuzzy-seas-compare.md

Co-authored-by: Yuchen Shi <[email protected]>

Author: mogaming217

.changeset/fuzzy-seas-compare.md

@@ -0,0 +1,5 @@
+---
+"@firebase/rules-unit-testing": patch
+---
+
+Fix assertFails() logic of @firebase/rules-unit-testing

packages/rules-unit-testing/src/api/index.ts

@@ -328,7 +328,8 @@ export function assertFails(pr: Promise<any>): any {
     },
     (err: any) => {
       const isPermissionDenied =
-        err && err.message && err.message.indexOf('PERMISSION_DENIED') >= 0;
+        (err && err.message && err.message.indexOf('PERMISSION_DENIED') >= 0) ||
+        (err && err.code === 'permission-denied');
       if (!isPermissionDenied) {
         return Promise.reject(
           new Error(

packages/rules-unit-testing/test/database.test.ts

@@ -67,6 +67,31 @@ describe('Testing Module Tests', function () {
       .catch(() => {});
   });
 
+  it('assertFails() if code is permission-denied', async function () {
+    const success = Promise.resolve('success');
+    const permissionDenied = Promise.reject({
+      code: 'permission-denied'
+    });
+    const otherFailure = Promise.reject('failure');
+    await firebase
+      .assertFails(success)
+      .then(() => {
+        throw new Error('Expected success to fail.');
+      })
+      .catch(() => {});
+
+    await firebase.assertFails(permissionDenied).catch(() => {
+      throw new Error('Expected permissionDenied to succeed.');
+    });
+
+    await firebase
+      .assertFails(otherFailure)
+      .then(() => {
+        throw new Error('Expected otherFailure to fail.');
+      })
+      .catch(() => {});
+  })
+
   it('initializeTestApp() with auth=null does not set access token', async function () {
     const app = firebase.initializeTestApp({
       projectId: 'foo',