Skip to content

Infer database URL from Project ID #3650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 8, 2020
Merged

Infer database URL from Project ID #3650

merged 5 commits into from
Sep 8, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2020 •
edited
Loading

🦋 Changeset is good to go

Latest commit: 86297b9

We got this.

This PR includes changesets to release 6 packages
Name Type
@firebase/database Patch
firebase Patch
@firebase/rules-unit-testing Patch
@firebase/testing Patch
firebase-namespace-integration-test Patch
firebase-messaging-integration-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 18, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (cc16b4a) Head (342d09e) Diff
    browser 269 kB 269 kB +85 B (+0.0%)
    esm2017 236 kB 236 kB +85 B (+0.0%)
    main 270 kB 270 kB +85 B (+0.0%)
    module 268 kB 268 kB +85 B (+0.0%)

  • firebase

    Type Base (cc16b4a) Head (342d09e) Diff
    firebase-database.js 186 kB 186 kB +124 B (+0.1%)
    firebase.js 821 kB 822 kB +124 B (+0.0%)

Test Logs

@fredzqm fredzqm removed their assignment Aug 18, 2020
@schmidt-sebastian
Copy link
Contributor Author

@jsdt - Do you mind taking a look?

schmidt-sebastian added a commit to firebase/firebase-android-sdk that referenced this pull request Aug 19, 2020
@schmidt-sebastian
Defer database URL from Project ID
77c3950 
Port of firebase/firebase-js-sdk#3650
@schmidt-sebastian schmidt-sebastian mentioned this pull request Aug 19, 2020
Merged
@schmidt-sebastian schmidt-sebastian changed the title Defer database URL from Project ID Infer database URL from Project ID Aug 19, 2020
@schmidt-sebastian schmidt-sebastian mentioned this pull request Aug 25, 2020
Merged
@jsdt
Copy link
Contributor

jsdt commented Aug 26, 2020

Will this work for old projects?

@schmidt-sebastian
Copy link
Contributor Author

@jsdt Do you have specific concerns? It will use the databaseURL param from the configuration if provided.

@fredzqm
Copy link
Contributor

fredzqm commented Aug 26, 2020 •
edited
Loading

Old projects will still have databaseUrl in the config.json.
New projects that conform to the new naming convention will no long have databaseUrl and this inference will kick in.

@schmidt-sebastian schmidt-sebastian requested review from a team as code owners September 8, 2020 15:52
@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (cc16b4a) and head commit (342d09e).

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit d347c6c into master Sep 8, 2020
@google-oss-bot google-oss-bot mentioned this pull request Sep 8, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Oct 9, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/optrtdburl branch November 9, 2020 22:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsdt jsdt jsdt approved these changes

@fredzqm fredzqm fredzqm approved these changes

@hsubox76 hsubox76 hsubox76 approved these changes

Assignees

@jsdt jsdt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@schmidt-sebastian @google-oss-bot @jsdt @fredzqm @hsubox76