Skip to content

Infer database URL from Project ID #1898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Conversation

schmidt-sebastian
Copy link
Contributor

@googlebot googlebot added the cla: yes Override cla label Aug 19, 2020
@schmidt-sebastian schmidt-sebastian changed the title Defer database URL from Project ID Infer database URL from Project ID Aug 19, 2020
@google-oss-bot
Copy link
Contributor

@schmidt-sebastian: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests afc2e55 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 19, 2020

Binary Size Report

Affected SDKs

  • firebase-database

    Type Base (4e9494b) Head (8a9d2a66) Diff
    aar 479 kB 479 kB +179 B (+0.0%)
    apk (release) 1.08 MB 1.08 MB +136 B (+0.0%)

Test Logs

Notes

Head commit (8a9d2a66) is created by Prow via merging commits: 4e9494b 77c3950.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Aug 19, 2020

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 51.07% (4e9494b) to 51.08% (70a7e204) by +0.01%.

    Filename Base (4e9494b) Head (70a7e204) Diff
    BooleanNode.java 92.31% 100.00% +7.69%
    FirebaseDatabase.java 29.11% 29.76% +0.65%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (70a7e204) is created by Prow via merging commits: 4e9494b afc2e55.

@schmidt-sebastian schmidt-sebastian merged commit ff1f63e into master Aug 20, 2020
@firebase firebase locked and limited conversation to collaborators Sep 20, 2020
@kaibolay kaibolay deleted the mrschmidt/rtdbport branch September 14, 2022 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants