Update Lite tests with Query API v2 #3446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
schmidt-sebastian
commented
Jul 21, 2020
•
schmidt-sebastian
commented
- Adds the Lite test to CI
- Fixes the Lite tests after the Query API changes
- Adds "converter" to Query and DocumentSnapshot API so TypeScript can deduce type of generic (without it all Queries return QuerySnapshot). I will add this to the API review right away.
- Fixes the IntelliJ test runner for firestore-exp and adds one for the Lite SDK.
💥 No ChangesetLatest commit: addcda1 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. This PR includes no changesetsWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
Binary Size ReportAffected SDKs
Test Logs |
schmidt-sebastian
force-pushed
the
mrschmidt/fixlitetests
branch
from
6061fb9 to
596f9c6
Compare
| @@ -68,7 +68,7 @@ export interface FirestoreDataConverter<T> { | |||
| toFirestore(modelObject: Partial<T>, options: SetOptions): DocumentData; | |||
| fromFirestore( | |||
| snapshot: QueryDocumentSnapshot<DocumentData>, | |||
| options: SnapshotOptions | |||
| options?: SnapshotOptions | |||
There was a problem hiding this comment.
Needed to make this interface compatible with the FirestoreDataConverter in lite.
schmidt-sebastian
requested review from
dconeybe and
thebrianchen
and removed request for
dconeybe
dconeybe
approved these changes
Jul 22, 2020
| @@ -177,7 +186,7 @@ describe('doc', () => { | |||
| 'Function doc() requires its second argument to be of type non-empty string, but it was: ""' | |||
| ); | |||
| expect(() => doc(collection(db, 'coll'), 'doc/coll')).to.throw( | |||
| 'Invalid document path (coll/doc/coll). Path points to a collection.' | |||
| 'Invalid document reference. Document references must have an even number of segments, but coll/doc/coll has 3.' | |||
| @@ -233,7 +242,7 @@ describe('collection', () => { | |||
| 'Function collection() requires its second argument to be of type non-empty string, but it was: ""' | |||
| ); | |||
| expect(() => collection(doc(db, 'coll/doc'), 'coll/doc')).to.throw( | |||
| 'Invalid collection path (coll/doc/coll/doc). Path points to a document.' | |||
| 'Invalid collection reference. Collection references must have an odd number of segments, but coll/doc/coll/doc has 4.' | |||
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.