Skip to content

Commit 7913ae9

Browse files
Update Lite tests with Query API v2 (#3446)
1 parent 9788c43 commit 7913ae9

16 files changed

+5907
-2878
lines changed

packages/firestore/.idea/runConfigurations/firestore_exp_Tests__Emulator__.xml

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/firestore/.idea/runConfigurations/firestore_exp_Tests__Emulator_w__Mock_Persistence_.xml

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/firestore/.idea/runConfigurations/firestore_lite_Tests__Emulator_.xml

+19
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/firestore/exp-types/index.d.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ export interface FirestoreDataConverter<T> {
6868
toFirestore(modelObject: Partial<T>, options: SetOptions): DocumentData;
6969
fromFirestore(
7070
snapshot: QueryDocumentSnapshot<DocumentData>,
71-
options: SnapshotOptions
71+
options?: SnapshotOptions
7272
): T;
7373
}
7474

@@ -242,9 +242,11 @@ export type SetOptions =
242242
export class DocumentReference<T = DocumentData> {
243243
private constructor();
244244
readonly type: 'document';
245-
readonly id: string;
246245
readonly firestore: FirebaseFirestore;
246+
readonly converter: FirestoreDataConverter<T> | null;
247247
readonly path: string;
248+
readonly id: string;
249+
248250
withConverter<U>(converter: FirestoreDataConverter<U>): DocumentReference<U>;
249251
}
250252

@@ -284,6 +286,7 @@ export class Query<T = DocumentData> {
284286
protected constructor();
285287
readonly type: 'query' | 'collection';
286288
readonly firestore: FirebaseFirestore;
289+
readonly converter: FirestoreDataConverter<T> | null;
287290

288291
withConverter<U>(converter: FirestoreDataConverter<U>): Query<U>;
289292
}

0 commit comments

Comments
 (0)