Remove Multi-Tab overhead for non-multi-tab persistence #3362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: f22f300 We got this. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| ], | ||
| "variables": [] | ||
| }, | ||
| "sizeInBytes": 335737 | ||
| "sizeInBytes": 311847 |
There was a problem hiding this comment.
This change drops about 24KB from enableIndexedDbPersistence.
Binary Size ReportAffected SDKs
Test Logs |
…js-sdk into mrschmidt/optmultitab
wu-hui
approved these changes
Jul 9, 2020
| ], | ||
| "variables": [] | ||
| }, | ||
| "sizeInBytes": 335737 | ||
| "sizeInBytes": 311847 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the name of existing IndexedDbComponentProvider to MultiTabComponentProvider and adds a new IndexedDbComponentProvider, which is used in firestore-exp to reduce the code size for users that use
enabledIndexedDbPersistenceinstead ofenableMultiTabIndexedDbPersistence. Unfortunately, we have to use MultiTabComponentProvider in the old SDK since we don't know which mode the SDK will end up picking.