Skip to content

Commit 064cf2e

Browse files
Make UserDataReader tree-shakeable (#3333)
1 parent c7aa053 commit 064cf2e

File tree

11 files changed

+2717
-551
lines changed

11 files changed

+2717
-551
lines changed

.changeset/four-melons-laugh.md

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
---
2+
---

packages/firestore/exp/src/api/reference.ts

+15-7
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,18 @@ import * as firestore from '../../index';
2222
import { Firestore } from './database';
2323
import {
2424
DocumentKeyReference,
25-
ParsedUpdateData
25+
ParsedUpdateData,
26+
parseSetData,
27+
parseUpdateData,
28+
parseUpdateVarargs
2629
} from '../../../src/api/user_data_reader';
2730
import { debugAssert } from '../../../src/util/assert';
2831
import { cast } from '../../../lite/src/api/util';
2932
import { DocumentSnapshot, QuerySnapshot } from './snapshot';
3033
import {
3134
addDocSnapshotListener,
32-
addSnapshotsInSyncListener,
3335
addQuerySnapshotListener,
36+
addSnapshotsInSyncListener,
3437
applyFirestoreDataConverter,
3538
getDocsViaSnapshotListener,
3639
getDocViaSnapshotListener,
@@ -175,7 +178,8 @@ export function setDoc<T>(
175178
options
176179
);
177180
const dataReader = newUserDataReader(firestore);
178-
const parsed = dataReader.parseSetData(
181+
const parsed = parseSetData(
182+
dataReader,
179183
'setDoc',
180184
ref._key,
181185
convertedValue,
@@ -215,15 +219,17 @@ export function updateDoc(
215219
typeof fieldOrUpdateData === 'string' ||
216220
fieldOrUpdateData instanceof FieldPath
217221
) {
218-
parsed = dataReader.parseUpdateVarargs(
222+
parsed = parseUpdateVarargs(
223+
dataReader,
219224
'updateDoc',
220225
ref._key,
221226
fieldOrUpdateData,
222227
value,
223228
moreFieldsAndValues
224229
);
225230
} else {
226-
parsed = dataReader.parseUpdateData(
231+
parsed = parseUpdateData(
232+
dataReader,
227233
'updateDoc',
228234
ref._key,
229235
fieldOrUpdateData
@@ -262,11 +268,13 @@ export function addDoc<T>(
262268
const convertedValue = applyFirestoreDataConverter(collRef._converter, data);
263269

264270
const dataReader = newUserDataReader(collRef.firestore);
265-
const parsed = dataReader.parseSetData(
271+
const parsed = parseSetData(
272+
dataReader,
266273
'addDoc',
267274
docRef._key,
268275
convertedValue,
269-
collRef._converter !== null
276+
collRef._converter !== null,
277+
{}
270278
);
271279

272280
return firestore

0 commit comments

Comments
 (0)