Skip to content

Make removeSnapshotsInSyncListener run on AQ #3090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2020
Merged

Make removeSnapshotsInSyncListener run on AQ #3090

merged 1 commit into from
May 19, 2020

Conversation

thebrianchen
Copy link

Porting from iOS.

@thebrianchen thebrianchen self-assigned this May 19, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (8bccfa5) Head (81b262a) Diff
    browser 251 kB 251 kB +59 B (+0.0%)
    esm2017 194 kB 194 kB +36 B (+0.0%)
    main 492 kB 492 kB +89 B (+0.0%)
    module 248 kB 248 kB +59 B (+0.0%)

  • @firebase/firestore/memory

    Type Base (8bccfa5) Head (81b262a) Diff
    browser 191 kB 191 kB +59 B (+0.0%)
    esm2017 149 kB 149 kB +36 B (+0.0%)
    main 368 kB 368 kB +89 B (+0.0%)
    module 189 kB 189 kB +59 B (+0.0%)

  • firebase

    Type Base (8bccfa5) Head (81b262a) Diff
    firebase-firestore.js 289 kB 289 kB +57 B (+0.0%)
    firebase-firestore.memory.js 231 kB 231 kB +57 B (+0.0%)
    firebase.js 823 kB 823 kB +57 B (+0.0%)

Test Logs

@thebrianchen thebrianchen changed the title Make removeSanpshotsInSyncListener run on AQ Make removeSnapshotsInSyncListener run on AQ May 19, 2020
@thebrianchen thebrianchen requested a review from wilhuff May 19, 2020 20:36
@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen May 19, 2020
wilhuff
wilhuff approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff May 19, 2020
@thebrianchen thebrianchen merged commit 597c0a0 into master May 19, 2020
@thebrianchen thebrianchen deleted the bc/enqueue-listen branch May 19, 2020 21:29
@firebase firebase locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thebrianchen @google-oss-bot @wilhuff