Make removeSanpshotsInSyncListener run on AQ (#3090)

Brian Chen · web-flow · commit 597c0a08557c · 2020-05-19T14:28:56.000-07:00
diff --git a/packages/firestore/src/core/firestore_client.ts b/packages/firestore/src/core/firestore_client.ts
@@ -497,7 +497,10 @@ export class FirestoreClient {
     if (this.clientTerminated) {
       return;
     }
-    this.eventMgr.removeSnapshotsInSyncListener(observer);
+    this.asyncQueue.enqueueAndForget(() => {
+      this.eventMgr.removeSnapshotsInSyncListener(observer);
+      return Promise.resolve();
+    });
   }
 
   get clientTerminated(): boolean {

Original file line number	Diff line number	Diff line change
`@@ -497,7 +497,10 @@ export class FirestoreClient {`
`497`	`497`	`if (this.clientTerminated) {`
`498`	`498`	`return;`
`499`	`499`	`}`
`500`		`- this.eventMgr.removeSnapshotsInSyncListener(observer);`
	`500`	`+ this.asyncQueue.enqueueAndForget(() => {`
	`501`	`+ this.eventMgr.removeSnapshotsInSyncListener(observer);`
	`502`	`+ return Promise.resolve();`
	`503`	`+ });`
`501`	`504`	`}`
`502`	`505`
`503`	`506`	`get clientTerminated(): boolean {`