Add ignoreUndefinedProperties #3077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs |
schmidt-sebastian
force-pushed
the
mrschmidt/ignoreundefined
branch
from
3228017 to
e2af49c
Compare
| @@ -461,7 +461,7 @@ export function validatePositiveNumber( | |||
| if (n <= 0) { | |||
| throw new FirestoreError( | |||
| Code.INVALID_ARGUMENT, | |||
| `Function "${functionName}()" requires its ${ordinal( | |||
| `Function ${functionName}() requires its ${ordinal( | |||
| position | |||
There was a problem hiding this comment.
Changed this to align this error message with the rest of the validation messages.
| @@ -310,9 +325,3 @@ export function withTestCollectionSettings( | |||
| } | |||
| ); | |||
| } | |||
|
|
|||
| function wipeDb(db: firestore.FirebaseFirestore): Promise<void> { | |||
There was a problem hiding this comment.
Removed this as I discovered this randomly. The call just gives the wrong illusion and we may actually not need to do this anymore since we are testing against the Emulator.
wu-hui
approved these changes
May 19, 2020
packages/firebase/index.d.ts
Outdated
| /** | ||
| * Whether to skip nested properties that are set to `undefined` during | ||
| * object serialization. If set to `true`, these properties will be skipped | ||
| * and are not be written to Firestore. If the setting is set `false` or |
There was a problem hiding this comment.
s/the setting is set/it is set to
egilmorez
reviewed
May 20, 2020
packages/firebase/index.d.ts
Outdated
|
|
||
| /** | ||
| * Whether to skip nested properties that are set to `undefined` during | ||
| * object serialization. If set to `true`, these properties will be skipped |
There was a problem hiding this comment.
Very much a nit, but we prefer present over future when possible. Here it cold be "properties are skipped . . . . the SDK throws . . ."
There was a problem hiding this comment.
Updated. Thanks for the review!
egilmorez
approved these changes
May 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of googleapis/nodejs-firestore#1062