Ensure run_changed errors on packages without test script (#3068)

Author: hsubox76

packages-exp/firebase-exp/package.json

@@ -30,7 +30,9 @@
     "build": "rollup -c && gulp firebase-js",
     "build:release": "rollup -c rollup.config.release.js && gulp firebase-js",
     "dev": "rollup -c -w",
-    "prepare": "yarn build:release"
+    "prepare": "yarn build:release",
+    "test": "echo 'No test suite for firebase wrapper'",
+    "test:ci": "echo 'No test suite for firebase wrapper'"
   },
   "dependencies": {
     "@firebase/app-exp": "0.0.800"

packages/firebase/package.json

@@ -36,7 +36,9 @@
     "build": "rollup -c",
     "build:deps": "lerna run --scope firebase --include-dependencies build",
     "dev": "rollup -c -w",
-    "prepare": "yarn build"
+    "prepare": "yarn build",
+    "test": "echo 'No test suite for firebase wrapper'",
+    "test:ci": "echo 'No test suite for firebase wrapper'"
   },
   "main": "dist/index.node.cjs.js",
   "browser": "dist/index.cjs.js",

packages/webchannel-wrapper/package.json

@@ -12,7 +12,9 @@
   "scripts": {
     "dev": "watch 'yarn build' src",
     "build": "gulp",
-    "prepare": "yarn build"
+    "prepare": "yarn build",
+    "test": "echo 'No test suite for webchannel-wrapper'",
+    "test:ci": "echo 'No test suite for webchannel-wrapper'"
   },
   "license": "Apache-2.0",
   "devDependencies": {

scripts/run_changed.js

@@ -25,6 +25,7 @@ const git = simpleGit(root);
 
 // use test:ci command in CI
 const testCommand = !!process.env.CI ? 'test:ci' : 'test';
+
 /**
  * Changes to these files warrant running all tests.
  */
@@ -104,10 +105,8 @@ async function getChangedPackages() {
     if (match && match[1]) {
       const changedPackage = require(resolve(root, match[1], 'package.json'));
       if (changedPackage) {
-        if (changedPackage.scripts.test) {
-          // Add the package itself.
-          changedPackages[match[1]] = 'direct';
-        }
+        // Add the package itself.
+        changedPackages[match[1]] = 'direct';
         // Add packages that depend on it.
         for (const package in depGraph) {
           if (depGraph[package].includes(changedPackage.name)) {
@@ -117,7 +116,7 @@ async function getChangedPackages() {
                 depData.location,
                 'package.json'
               ));
-              if (depPkgJson && depPkgJson.scripts.test) {
+              if (depPkgJson) {
                 const depPath = depData.location.replace(`${root}/`, '');
                 if (!changedPackages[depPath]) {
                   changedPackages[depPath] = 'dependency';
@@ -154,7 +153,7 @@ async function runTests(pathList) {
         stdio: 'inherit'
       });
     } catch (e) {
-      throw new Error(`Error running tests in ${testPath}.`);
+      throw new Error(`Error running "yarn ${testCommand}" in ${testPath}.`);
     }
   }
 }
@@ -186,7 +185,7 @@ async function main() {
       await runTests(Object.keys(changedPackages));
     }
   } catch (e) {
-    console.error(e);
+    console.error(chalk`{red ${e}}`);
     process.exit(1);
   }
 }