Skip to content

Make instance logLevel setter able to process string input #3076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2020
Merged

Conversation

hsubox76
Copy link
Contributor

When Firestore and other users of Logger set log level on their instance only, this change allows them to use string input in addition to LogLevel enums. Firestore has a public interface that takes string input (just as the top-level setLogLevel() does) and needs to use this input to set logLevel on the Firestore logger instance only.

@hsubox76
Copy link
Contributor Author

Needed to make an additional setter method because built-in getters and setters are required to be the same type.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/logger

    Type Base (ac215cf) Head (93b9e1c) Diff
    esm2017 3.22 kB 3.25 kB +23 B (+0.7%)
    main 5.09 kB 5.14 kB +51 B (+1.0%)
    module 4.78 kB 4.83 kB +51 B (+1.1%)
  • firebase

    Type Base (ac215cf) Head (93b9e1c) Diff
    firebase-analytics.js 26.5 kB 26.6 kB +130 B (+0.5%)
    firebase-app.js 19.9 kB 19.9 kB +58 B (+0.3%)
    firebase-database.js 187 kB 187 kB +132 B (+0.1%)
    firebase-firestore.js 288 kB 289 kB +130 B (+0.0%)
    firebase-firestore.memory.js 230 kB 230 kB +130 B (+0.1%)
    firebase-performance-standalone.es2017.js 72.7 kB 72.7 kB +35 B (+0.0%)
    firebase-performance-standalone.js 48.1 kB 48.2 kB +58 B (+0.1%)
    firebase-performance.js 38.5 kB 38.6 kB +130 B (+0.3%)
    firebase-remote-config.js 36.9 kB 37.0 kB +130 B (+0.4%)
    firebase.js 822 kB 822 kB +59 B (+0.0%)

Test Logs

@Feiyang1
Copy link
Member

Do you have the link to the Firestore PR?

@hsubox76
Copy link
Contributor Author

@hsubox76 hsubox76 merged commit 67adfb2 into master May 27, 2020
@hsubox76 hsubox76 deleted the ch-log branch June 18, 2020 21:09
@firebase firebase locked and limited conversation to collaborators Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants