Fix GeoPoint field values with a zero coordinate failing input validation
#3018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var-const
commented
May 5, 2020
| value.geoPointValue!.latitude!, | ||
| value.geoPointValue!.longitude! | ||
| ); | ||
| // `geoPointValue` stores zeroes as undefined, which will fail |
There was a problem hiding this comment.
Sebastian, can you think of any other types that might be affected? Timestamp, I think, isn't.
There was a problem hiding this comment.
Timestamp goes through normalizeNumber() which turns undefined into 0. Do you want to follow this pattern here as well and invoke normalizeNumber()? It also correctly handles NaN and Infinity, which should never be part of a GeoPoint, but who knows where 2020 is going to take us.
There was a problem hiding this comment.
Done (and extracted into a small helper function for consistency with Timestamp et al.).
schmidt-sebastian
approved these changes
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the regression introduced in #2784: a
GeoPointwhere at least one of the coordinates is zero doesn't marshal properly. This is because zeroes happen to be serialized asundefined(presumably because protos normally treat zero values and the absence of a value interchangeably) which then fails the strict input validation inGeoPoint.Fixes #3006.