Skip to content

Update SourceMaps during transform #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2020
Merged

Update SourceMaps during transform #3011

merged 1 commit into from
May 4, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

No description provided.

@schmidt-sebastian schmidt-sebastian force-pushed the mrschmidt/updatesourcemaps branch from a9dba4b to 068c32a Compare May 4, 2020 19:41
@google-oss-bot
Copy link
Contributor

google-oss-bot commented May 4, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (df44d12) and head commit (c183d5d).

Test Logs

@schmidt-sebastian
Copy link
Contributor Author

Example from before that failed to map renamed members:

Screen Shot 2020-05-04 at 1 09 53 PM

Example with PR:

Screen Shot 2020-05-04 at 1 07 50 PM

@schmidt-sebastian schmidt-sebastian requested a review from Feiyang1 May 4, 2020 20:10
@schmidt-sebastian schmidt-sebastian merged commit da3582b into master May 4, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/updatesourcemaps branch May 4, 2020 23:15
@firebase firebase locked and limited conversation to collaborators Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

Assignees

@Feiyang1 Feiyang1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schmidt-sebastian @google-oss-bot @Feiyang1