Update SourceMaps during transform

Author: schmidt-sebastian

packages/firestore/package.json

@@ -56,6 +56,7 @@
   "devDependencies": {
     "@types/json-stable-stringify": "1.0.32",
     "json-stable-stringify": "1.0.1",
+    "magic-string": "0.25.7",
     "protobufjs": "6.8.9",
     "rollup": "2.6.1",
     "rollup-plugin-copy-assets": "1.1.0",

packages/firestore/scripts/remove-asserts.ts

@@ -49,6 +49,8 @@ class RemoveAsserts {
   }
 
   visitNode(node: ts.Node): ts.Node {
+    let updatedNode: ts.Node | null = null;
+
     if (ts.isCallExpression(node)) {
       const signature = this.typeChecker.getResolvedSignature(node);
       if (
@@ -63,19 +65,31 @@ class RemoveAsserts {
         ) {
           const method = declaration.name!.text;
           if (method === 'debugAssert') {
-            return ts.createEmptyStatement();
+            updatedNode = ts.createEmptyStatement();
           } else if (method === 'hardAssert') {
             // Remove the log message but keep the assertion
-            return ts.createCall(declaration.name!, /*typeArgs*/ undefined, [
-              node.arguments[0]
-            ]);
+            updatedNode = ts.createCall(
+              declaration.name!,
+              /*typeArgs*/ undefined,
+              [node.arguments[0]]
+            );
           } else if (method === 'fail') {
             // Remove the log message
-            return ts.createCall(declaration.name!, /*typeArgs*/ undefined, []);
+            updatedNode = ts.createCall(
+              declaration.name!,
+              /*typeArgs*/ undefined,
+              []
+            );
           }
         }
       }
     }
-    return node;
+
+    if (updatedNode) {
+      ts.setSourceMapRange(updatedNode, ts.getSourceMapRange(node));
+      return updatedNode;
+    } else {
+      return node;
+    }
   }
 }

packages/firestore/scripts/rename-internals.ts

@@ -49,7 +49,9 @@ class RenameInternals {
         !this.publicApi.has(name) &&
         blacklist.indexOf(node.escapedText.toString()) === -1
       ) {
-        return ts.createIdentifier(this.prefix + name);
+        const newIdentifier = ts.createIdentifier(this.prefix + name);
+        ts.setSourceMapRange(newIdentifier, ts.getSourceMapRange(node));
+        return newIdentifier;
       }
     }