Skip to content

Standardize auth-next style #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 24, 2020
Merged

Standardize auth-next style #2983

merged 3 commits into from
Apr 24, 2020

Conversation

avolkovi
Copy link
Contributor

@avolkovi avolkovi commented Apr 24, 2020 •
edited
Loading

  • prefix directory for test blocks
  • use kebab case for test values to make them visually distinct from
    keys
  • use '#' to prefix instance methods and '.' for class methods
  • prefix all private exported methods with '_'

avolkovi added 2 commits April 24, 2020 09:42
@avolkovi
Standardize auth-next style
9ddbaac 
- prefix directory for test blocks
- use kebab style for test values to make them visually distinct from
keys
- use '#' to prefix instance methods and '.' for class methods
- prefix all private exported methods with '_'
@avolkovi
[AUTOMATED]: Prettier Code Styling
41a9789
@avolkovi avolkovi requested review from sam-gc and scottcrossen April 24, 2020 16:44
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 24, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (37a89ca) and head commit (1f8c971).

Test Logs

sam-gc
sam-gc approved these changes Apr 24, 2020
View reviewed changes
Copy link
Contributor

@sam-gc sam-gc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

@avolkovi avolkovi merged commit 27910ee into auth-next Apr 24, 2020
@avolkovi avolkovi deleted the avolkovi/auth-next-standardise branch April 24, 2020 16:58
sam-gc pushed a commit that referenced this pull request May 19, 2020
@avolkovi @sam-gc
Standardize auth-next style (#2983)
e77959e 
* Standardize auth-next style

- prefix directory for test blocks
- use kebab style for test values to make them visually distinct from
keys
- use '#' to prefix instance methods and '.' for class methods
- prefix all private exported methods with '_'

* [AUTOMATED]: Prettier Code Styling

* Two more cases I missed
@firebase firebase locked and limited conversation to collaborators May 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc approved these changes

@scottcrossen scottcrossen Awaiting requested review from scottcrossen

@Feiyang1 Feiyang1 Awaiting requested review from Feiyang1

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@avolkovi @google-oss-bot @sam-gc