Skip to content

Commit e77959e

Browse files
avolkovisam-gc
authored andcommitted
Standardize auth-next style (#2983)
* Standardize auth-next style - prefix directory for test blocks - use kebab style for test values to make them visually distinct from keys - use '#' to prefix instance methods and '.' for class methods - prefix all private exported methods with '_' * [AUTOMATED]: Prettier Code Styling * Two more cases I missed
1 parent deab6e3 commit e77959e

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

50 files changed

+285
-291
lines changed

packages-exp/auth-exp/src/api/account_management/account.test.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import { deleteAccount, deleteLinkedAccounts, getAccountInfo } from './account';
2828

2929
use(chaiAsPromised);
3030

31-
describe('deleteAccount', () => {
31+
describe('api/account_management/deleteAccount', () => {
3232
const request = {
3333
idToken: 'id-token'
3434
};
@@ -73,7 +73,7 @@ describe('deleteAccount', () => {
7373
});
7474
});
7575

76-
describe('deleteLinkedAccounts', () => {
76+
describe('api/account_management/deleteLinkedAccounts', () => {
7777
const request = {
7878
idToken: 'id-token',
7979
deleteProvider: [ProviderId.GOOGLE]
@@ -128,7 +128,7 @@ describe('deleteLinkedAccounts', () => {
128128
});
129129
});
130130

131-
describe('getAccountInfo', () => {
131+
describe('api/account_management/getAccountInfo', () => {
132132
const request = {
133133
idToken: 'id-token'
134134
};

packages-exp/auth-exp/src/api/account_management/account.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18-
import { Endpoint, HttpMethod, performApiRequest } from '../';
18+
import { Endpoint, HttpMethod, _performApiRequest } from '../';
1919
import { Auth } from '../../model/auth';
2020
import { APIMFAInfo } from '../../model/id_token';
2121

@@ -27,7 +27,7 @@ export async function deleteAccount(
2727
auth: Auth,
2828
request: DeleteAccountRequest
2929
): Promise<void> {
30-
return performApiRequest<DeleteAccountRequest, void>(
30+
return _performApiRequest<DeleteAccountRequest, void>(
3131
auth,
3232
HttpMethod.POST,
3333
Endpoint.DELETE_ACCOUNT,
@@ -57,7 +57,7 @@ export async function deleteLinkedAccounts(
5757
auth: Auth,
5858
request: DeleteLinkedAccountsRequest
5959
): Promise<DeleteLinkedAccountsResponse> {
60-
return performApiRequest<
60+
return _performApiRequest<
6161
DeleteLinkedAccountsRequest,
6262
DeleteLinkedAccountsResponse
6363
>(auth, HttpMethod.POST, Endpoint.SET_ACCOUNT_INFO, request);
@@ -90,7 +90,7 @@ export async function getAccountInfo(
9090
auth: Auth,
9191
request: GetAccountInfoRequest
9292
): Promise<GetAccountInfoResponse> {
93-
return performApiRequest<GetAccountInfoRequest, GetAccountInfoResponse>(
93+
return _performApiRequest<GetAccountInfoRequest, GetAccountInfoResponse>(
9494
auth,
9595
HttpMethod.POST,
9696
Endpoint.GET_ACCOUNT_INFO,

packages-exp/auth-exp/src/api/account_management/email_and_password.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { resetPassword, updateEmailPassword } from './email_and_password';
2727

2828
use(chaiAsPromised);
2929

30-
describe('resetPassword', () => {
30+
describe('api/account_management/resetPassword', () => {
3131
const request = {
3232
oobCode: 'oob-code',
3333
newPassword: 'new-password'
@@ -76,7 +76,7 @@ describe('resetPassword', () => {
7676
});
7777
});
7878

79-
describe('updateEmailPassword', () => {
79+
describe('api/account_management/updateEmailPassword', () => {
8080
const request = {
8181
idToken: 'id-token',
8282
returnSecureToken: true,

packages-exp/auth-exp/src/api/account_management/email_and_password.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18-
import { Endpoint, HttpMethod, performApiRequest } from '..';
18+
import { Endpoint, HttpMethod, _performApiRequest } from '..';
1919
import { Operation } from '../../model/action_code_info';
2020
import { Auth } from '../../model/auth';
2121
import { IdTokenResponse } from '../../model/id_token';
@@ -35,7 +35,7 @@ export async function resetPassword(
3535
auth: Auth,
3636
request: ResetPasswordRequest
3737
): Promise<ResetPasswordResponse> {
38-
return performApiRequest<ResetPasswordRequest, ResetPasswordResponse>(
38+
return _performApiRequest<ResetPasswordRequest, ResetPasswordResponse>(
3939
auth,
4040
HttpMethod.POST,
4141
Endpoint.RESET_PASSWORD,
@@ -55,7 +55,7 @@ export async function updateEmailPassword(
5555
auth: Auth,
5656
request: UpdateEmailPasswordRequest
5757
): Promise<UpdateEmailPasswordResponse> {
58-
return performApiRequest<
58+
return _performApiRequest<
5959
UpdateEmailPasswordRequest,
6060
UpdateEmailPasswordResponse
6161
>(auth, HttpMethod.POST, Endpoint.SET_ACCOUNT_INFO, request);

packages-exp/auth-exp/src/api/account_management/mfa.test.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { enrollPhoneMfa, startEnrollPhoneMfa, withdrawMfa } from './mfa';
2727

2828
use(chaiAsPromised);
2929

30-
describe('startEnrollPhoneMfa', () => {
30+
describe('api/account_management/startEnrollPhoneMfa', () => {
3131
const request = {
3232
idToken: 'id-token',
3333
phoneEnrollmentInfo: {
@@ -81,7 +81,7 @@ describe('startEnrollPhoneMfa', () => {
8181
});
8282
});
8383

84-
describe('enrollPhoneMfa', () => {
84+
describe('api/account_management/enrollPhoneMfa', () => {
8585
const request = {
8686
phoneVerificationInfo: {
8787
temporaryProof: 'temporary-proof',
@@ -136,7 +136,7 @@ describe('enrollPhoneMfa', () => {
136136
});
137137
});
138138

139-
describe('withdrawMfa', () => {
139+
describe('api/account_management/withdrawMfa', () => {
140140
const request = {
141141
idToken: 'id-token',
142142
mfaEnrollmentId: 'mfa-enrollment-id'

packages-exp/auth-exp/src/api/account_management/mfa.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18-
import { Endpoint, HttpMethod, performApiRequest } from '..';
18+
import { Endpoint, HttpMethod, _performApiRequest } from '..';
1919
import { Auth } from '../../model/auth';
2020
import { IdTokenResponse } from '../../model/id_token';
2121
import { SignInWithPhoneNumberRequest } from '../authentication/sms';
@@ -39,7 +39,7 @@ export function startEnrollPhoneMfa(
3939
auth: Auth,
4040
request: StartPhoneMfaEnrollmentRequest
4141
): Promise<StartPhoneMfaEnrollmentResponse> {
42-
return performApiRequest<
42+
return _performApiRequest<
4343
StartPhoneMfaEnrollmentRequest,
4444
StartPhoneMfaEnrollmentResponse
4545
>(auth, HttpMethod.POST, Endpoint.START_PHONE_MFA_ENROLLMENT, request);
@@ -55,7 +55,7 @@ export function enrollPhoneMfa(
5555
auth: Auth,
5656
request: PhoneMfaEnrollmentRequest
5757
): Promise<PhoneMfaEnrollmentResponse> {
58-
return performApiRequest<
58+
return _performApiRequest<
5959
PhoneMfaEnrollmentRequest,
6060
PhoneMfaEnrollmentResponse
6161
>(auth, HttpMethod.POST, Endpoint.FINALIZE_PHONE_MFA_ENROLLMENT, request);
@@ -72,7 +72,7 @@ export function withdrawMfa(
7272
auth: Auth,
7373
request: WithdrawMfaRequest
7474
): Promise<WithdrawMfaResponse> {
75-
return performApiRequest<WithdrawMfaRequest, WithdrawMfaResponse>(
75+
return _performApiRequest<WithdrawMfaRequest, WithdrawMfaResponse>(
7676
auth,
7777
HttpMethod.POST,
7878
Endpoint.WITHDRAW_MFA,

packages-exp/auth-exp/src/api/account_management/profile.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { updateProfile } from './profile';
2727

2828
use(chaiAsPromised);
2929

30-
describe('updateProfile', () => {
30+
describe('api/account_management/updateProfile', () => {
3131
const request = {
3232
idToken: 'my-token',
3333

packages-exp/auth-exp/src/api/account_management/profile.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18-
import { Endpoint, HttpMethod, performApiRequest } from '..';
18+
import { Endpoint, HttpMethod, _performApiRequest } from '..';
1919
import { Auth } from '../../model/auth';
2020
import { IdTokenResponse } from '../../model/id_token';
2121

@@ -34,7 +34,7 @@ export async function updateProfile(
3434
auth: Auth,
3535
request: UpdateProfileRequest
3636
): Promise<UpdateProfileResponse> {
37-
return performApiRequest<UpdateProfileRequest, UpdateProfileResponse>(
37+
return _performApiRequest<UpdateProfileRequest, UpdateProfileResponse>(
3838
auth,
3939
HttpMethod.POST,
4040
Endpoint.SET_ACCOUNT_INFO,

packages-exp/auth-exp/src/api/authentication/create_auth_uri.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ import { createAuthUri } from './create_auth_uri';
2727

2828
use(chaiAsPromised);
2929

30-
describe('createAuthUri', () => {
30+
describe('api/authentication/createAuthUri', () => {
3131
const request = {
3232
identifier: 'my-id',
3333
continueUri: 'example.com/redirectUri'

packages-exp/auth-exp/src/api/authentication/create_auth_uri.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18-
import { Endpoint, HttpMethod, performApiRequest } from '..';
18+
import { Endpoint, HttpMethod, _performApiRequest } from '..';
1919
import { Auth } from '../../model/auth';
2020

2121
export interface CreateAuthUriRequest {
@@ -31,7 +31,7 @@ export async function createAuthUri(
3131
auth: Auth,
3232
request: CreateAuthUriRequest
3333
): Promise<CreateAuthUriResponse> {
34-
return performApiRequest<CreateAuthUriRequest, CreateAuthUriResponse>(
34+
return _performApiRequest<CreateAuthUriRequest, CreateAuthUriResponse>(
3535
auth,
3636
HttpMethod.POST,
3737
Endpoint.CREATE_AUTH_URI,

packages-exp/auth-exp/src/api/authentication/custom_token.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ import { signInWithCustomToken } from './custom_token';
2828

2929
use(chaiAsPromised);
3030

31-
describe('signInWithCustomToken', () => {
31+
describe('api/authentication/signInWithCustomToken', () => {
3232
const request = {
3333
token: 'my-token'
3434
};

packages-exp/auth-exp/src/api/authentication/custom_token.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* limitations under the License.
1616
*/
1717

18-
import { Endpoint, HttpMethod, performSignInRequest } from '..';
18+
import { Endpoint, HttpMethod, _performSignInRequest } from '..';
1919
import { Auth } from '../../model/auth';
2020
import { IdTokenResponse } from '../../model/id_token';
2121

@@ -29,7 +29,7 @@ export async function signInWithCustomToken(
2929
auth: Auth,
3030
request: SignInWithCustomTokenRequest
3131
): Promise<SignInWithCustomTokenResponse> {
32-
return performSignInRequest<
32+
return _performSignInRequest<
3333
SignInWithCustomTokenRequest,
3434
SignInWithCustomTokenResponse
3535
>(auth, HttpMethod.POST, Endpoint.SIGN_IN_WITH_CUSTOM_TOKEN, request);

0 commit comments

Comments
 (0)