Add react native persistence class #2955
Conversation
scottcrossen
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
scottcrossen
force-pushed
the
slc/react-native-persistence
branch
from
59a9b58 to
51520a5
Compare
| @@ -23,5 +23,9 @@ | |||
| */ | |||
|
|
|||
| import { testFxn } from './src'; | |||
| import { AsyncStorage } from 'react-native'; | |||
There was a problem hiding this comment.
it'd be great if the storage layer were injectable, so if someone were to want to sub in something for AsyncStorage they would be able to do that provided that it conforms to the same interface. redux-persist provides a storage option used on initialization: https://github.com/rt2zz/redux-persist#v6-upgrade
There was a problem hiding this comment.
That is the overall idea, but this is a polyfill and maintains the legacy behavior.
There was a problem hiding this comment.
I see that you're big into expo contributions! Is there anything else you think would be helpful from the firebase auth SDK?
There was a problem hiding this comment.
hey @scottcrossen! @EvanBacon has been doing a bunch of work on authentication apis in expo recently, he may have some questions for you.
can we invite you to our slack to discuss further? if you let me know your email i'd be happy to invite you and other folks on your team so we can collaborate further.
There was a problem hiding this comment.
Sure sounds good! Email me to get me setup [email protected]
scottcrossen
force-pushed
the
slc/react-native-persistence
branch
from
51520a5 to
ee628c4
Compare
scottcrossen
requested review from
sam-gc,
Feiyang1,
avolkovi,
bojeil-google and
hsubox76
scottcrossen
force-pushed
the
slc/react-native-persistence
branch
from
ee628c4 to
71de830
Compare
avolkovi
force-pushed
the
auth-next
branch
2 times, most recently
from
b792887 to
a484d4f
Compare
scottcrossen
force-pushed
the
slc/react-native-persistence
branch
from
c7a9980 to
bfbf208
Compare
packages-exp/auth-exp/src/core/persistence/react_native.test.ts
Outdated
Show resolved
Hide resolved
scottcrossen
force-pushed
the
slc/react-native-persistence
branch
from
99a4fd6 to
079d642
Compare
scottcrossen
force-pushed
the
slc/react-native-persistence
branch
from
079d642 to
e9fbcec
Compare
scottcrossen
requested review from
erikeldridge,
jamesdaniels,
jsdt,
schmidt-sebastian,
wti806,
yuchenshi,
zijianjoy and
zwu52
as code owners
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
scottcrossen
force-pushed
the
slc/react-native-persistence
branch
from
e9fbcec to
598d941
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
scottcrossen
removed request for
alikn,
andirayo,
davideast,
erikeldridge,
jamesdaniels,
jsdt,
schmidt-sebastian,
wti806,
yuchenshi,
zijianjoy and
zwu52
Added React Native persistence class
No description provided.