Responded to reviewer comments

Author: scottcrossen

packages-exp/auth-compat-exp/index.rn.ts

@@ -25,4 +25,5 @@
 import { AsyncStorage } from 'react-native';
 import { ReactNativePersistence } from '@firebase/auth-exp/src/core/persistence/react_native';
 
-const _reactNativeLocalPersistence = new ReactNativePersistence(AsyncStorage);
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
+const reactNativeLocalPersistence = new ReactNativePersistence(AsyncStorage);

packages-exp/auth-compat-exp/react-native.d.ts

@@ -27,9 +27,9 @@
 
 declare module 'react-native' {
   interface ReactNativeAsyncStorage {
-    setItem(key: string, value: string): Promise<void>
-    getItem(key: string): Promise<string | null>
-    removeItem(key: string): Promise<void>
+    setItem(key: string, value: string): Promise<void>;
+    getItem(key: string): Promise<string | null>;
+    removeItem(key: string): Promise<void>;
   }
   export const AsyncStorage: ReactNativeAsyncStorage;
 }

packages-exp/auth-exp/src/core/persistence/react_native.test.ts

@@ -32,7 +32,7 @@ class FakeAsyncStorage implements ReactNativeAsyncStorage {
 
   async getItem(key: string): Promise<string | null> {
     const value = this.storage[key];
-    return value === undefined ? null : value;
+    return value ?? null;
   }
   async removeItem(key: string): Promise<void> {
     delete this.storage[key];

packages-exp/auth-exp/src/core/persistence/react_native.ts

@@ -28,11 +28,8 @@ import {ReactNativeAsyncStorage} from '@firebase/auth-types-exp';
  */
 export class ReactNativePersistence implements Persistence {
   readonly type: PersistenceType = PersistenceType.LOCAL;
-  private readonly storage: ReactNativeAsyncStorage;
 
-  constructor(storage: ReactNativeAsyncStorage) {
-    this.storage = storage;
-  }
+  constructor(private readonly storage: ReactNativeAsyncStorage) {}
 
   async isAvailable(): Promise<boolean> {
     try {

packages-exp/auth-types-exp/index.d.ts

@@ -16,7 +16,7 @@
  */
 
 export interface ReactNativeAsyncStorage {
-  setItem(key: string, value: string): Promise<void>
-  getItem(key: string): Promise<string | null>
-  removeItem(key: string): Promise<void>
+  setItem(key: string, value: string): Promise<void>;
+  getItem(key: string): Promise<string | null>;
+  removeItem(key: string): Promise<void>;
 }

yarn.lock

@@ -12592,6 +12592,17 @@ [email protected]:
     rollup-pluginutils "2.8.2"
     tslib "1.10.0"
 
+[email protected]:
+  version "0.26.0"
+  resolved "https://registry.npmjs.org/rollup-plugin-typescript2/-/rollup-plugin-typescript2-0.26.0.tgz#cee2b44d51d9623686656d76dc30a73c4de91672"
+  integrity sha512-lUK7XZVG77tu8dmv1L/0LZFlavED/5Yo6e4iMMl6fdox/yKdj4IFRRPPJEXNdmEaT1nDQQeCi7b5IwKHffMNeg==
+  dependencies:
+    find-cache-dir "^3.2.0"
+    fs-extra "8.1.0"
+    resolve "1.15.1"
+    rollup-pluginutils "2.8.2"
+    tslib "1.10.0"
+
 [email protected]:
   version "0.27.0"
   resolved "https://registry.npmjs.org/rollup-plugin-typescript2/-/rollup-plugin-typescript2-0.27.0.tgz#95ff96f9e07d5000a9d2df4d76b548f9a1f83511"
@@ -12613,6 +12624,13 @@ [email protected]:
     serialize-javascript "^2.1.2"
     uglify-js "^3.4.9"
 
+[email protected]:
+  version "2.8.1"
+  resolved "https://registry.npmjs.org/rollup-pluginutils/-/rollup-pluginutils-2.8.1.tgz#8fa6dd0697344938ef26c2c09d2488ce9e33ce97"
+  integrity sha512-J5oAoysWar6GuZo0s+3bZ6sVZAC0pfqKz68De7ZgDi5z63jOVZn1uJL/+z1jeKHNbGII8kAyHF5q8LnxSX5lQg==
+  dependencies:
+    estree-walker "^0.6.1"
+
 [email protected], rollup-pluginutils@^2.5.0, rollup-pluginutils@^2.6.0, rollup-pluginutils@^2.8.1, rollup-pluginutils@^2.8.2:
   version "2.8.2"
   resolved "https://registry.npmjs.org/rollup-pluginutils/-/rollup-pluginutils-2.8.2.tgz#72f2af0748b592364dbd3389e600e5a9444a351e"