Skip to content

Add version helpers to auth-next #2910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 16, 2020
Merged

Add version helpers to auth-next #2910

merged 3 commits into from
Apr 16, 2020

Conversation

avolkovi
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 14, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

No changes between base commit (11dd5ee) and head commit (4e92cbe).

Test Logs

Feiyang1
Feiyang1 suggested changes Apr 15, 2020
View reviewed changes
@avolkovi avolkovi force-pushed the avolkovi/auth-next-version branch from f60acd7 to e4323bd Compare April 16, 2020 17:35
@avolkovi avolkovi merged commit cb6ef17 into auth-next Apr 16, 2020
@avolkovi avolkovi deleted the avolkovi/auth-next-version branch April 16, 2020 18:07
avolkovi added a commit that referenced this pull request Apr 22, 2020
@avolkovi
Add version helpers to auth-next (#2910)
ab398fd 
* Add version helper to auth-next

* [AUTOMATED]: Prettier Code Styling

* PR feedback
avolkovi added a commit that referenced this pull request Apr 23, 2020
@avolkovi
Add version helpers to auth-next (#2910)
b9bdfe9 
* Add version helper to auth-next

* [AUTOMATED]: Prettier Code Styling

* PR feedback
avolkovi added a commit that referenced this pull request Apr 24, 2020
@avolkovi
Add version helpers to auth-next (#2910)
2cd3c85 
* Add version helper to auth-next

* [AUTOMATED]: Prettier Code Styling

* PR feedback
@firebase firebase locked and limited conversation to collaborators May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam-gc sam-gc sam-gc left review comments

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@bojeil-google bojeil-google Awaiting requested review from bojeil-google

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@hsubox76 hsubox76 Awaiting requested review from hsubox76 hsubox76 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avolkovi @google-oss-bot @sam-gc @Feiyang1