PR feedback

Author: avolkovi

packages-exp/auth-exp/package.json

@@ -29,7 +29,6 @@
     "@firebase/app-types-exp": "0.x"
   },
   "dependencies": {
-    "@firebase/app": "^0.6.1",
     "@firebase/util": "^0.2.44",
     "tslib": "1.11.1"
   },

packages-exp/auth-exp/src/core/util/browser.ts

@@ -74,9 +74,9 @@ export function getBrowserName(userAgent: string): BrowserName | string {
     return BrowserName.ANDROID;
   } else {
     // Most modern browsers have name/version at end of user agent string.
-    const re = new RegExp('([a-zA-Z\\d\\.]+)/[a-zA-Z\\d\\.]*$');
+    const re = /([a-zA-Z\d\.]+)\/[a-zA-Z\d\.]*$/;
     const matches = userAgent.match(re);
-    if (matches && matches.length === 2) {
+    if (matches?.length === 2) {
       return matches[1];
     }
   }

packages-exp/auth-exp/src/core/util/version.test.ts

@@ -15,31 +15,31 @@
  * limitations under the License.
  */
 
-import firebase from '@firebase/app';
+import { SDK_VERSION } from '@firebase/app-exp';
 import { expect } from 'chai';
 import { ClientPlatform, getClientVersion } from './version';
 
 describe('getClientVersion', () => {
   context('browser', () => {
     it('should set the correct version', () => {
       expect(getClientVersion(ClientPlatform.BROWSER)).to.eq(
-        `Chrome/JsCore/${firebase.SDK_VERSION}/FirebaseCore-web`
+        `Chrome/JsCore/${SDK_VERSION}/FirebaseCore-web`
       );
     });
   });
 
   context('worker', () => {
     it('should set the correct version', () => {
       expect(getClientVersion(ClientPlatform.WORKER)).to.eq(
-        `Chrome-Worker/JsCore/${firebase.SDK_VERSION}/FirebaseCore-web`
+        `Chrome-Worker/JsCore/${SDK_VERSION}/FirebaseCore-web`
       );
     });
   });
 
   context('React Native', () => {
     it('should set the correct version', () => {
       expect(getClientVersion(ClientPlatform.REACT_NATIVE)).to.eq(
-        `ReactNative/JsCore/${firebase.SDK_VERSION}/FirebaseCore-web`
+        `ReactNative/JsCore/${SDK_VERSION}/FirebaseCore-web`
       );
     });
   });

packages-exp/auth-exp/src/core/util/version.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-import firebase from '@firebase/app';
+import { SDK_VERSION } from '@firebase/app-exp';
 import { getBrowserName } from './browser';
 import { getUA } from '@firebase/util';
 
@@ -57,5 +57,5 @@ export function getClientVersion(clientPlatform: ClientPlatform): string {
     default:
       reportedPlatform = clientPlatform;
   }
-  return `${reportedPlatform}/${CLIENT_IMPLEMENTATION}/${firebase.SDK_VERSION}/${ClientFramework.DEFAULT}`;
+  return `${reportedPlatform}/${CLIENT_IMPLEMENTATION}/${SDK_VERSION}/${ClientFramework.DEFAULT}`;
 }