Skip to content

Revert: Use crypo RNG for auto ID generation to reduce conflicts #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2020
Merged

Revert: Use crypo RNG for auto ID generation to reduce conflicts #2872

merged 2 commits into from
Apr 6, 2020

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Apr 6, 2020 •
edited
Loading

This temporarily reverts #2764 because of issues encountered by users. We'll roll that forward again when we have a version of the PR that addresses #2832, #2858, and #2870.

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

SDKTypeBase (5b90965)Head (19d77d6)Diff
@firebase/firestore/memorybrowser212492.00212256.00-236.00 (-0.11%)
module210858.00210622.00-236.00 (-0.11%)
esm2017169548.00169342.00-206.00 (-0.12%)
main376232.00375934.00-298.00 (-0.08%)
@firebase/firestorebrowser268827.00268591.00-236.00 (-0.09%)
module266798.00266562.00-236.00 (-0.09%)
esm2017215260.00215054.00-206.00 (-0.10%)
main486884.00486586.00-298.00 (-0.06%)
firebasefirebase.js846043.00845806.00-237.00 (-0.03%)
firebase-firestore.memory.js255892.00255655.00-237.00 (-0.09%)
firebase-firestore.js310955.00310718.00-237.00 (-0.08%)
Metric Unit: byte

Test Logs

wilhuff
wilhuff approved these changes Apr 6, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schmidt-sebastian
Copy link
Contributor

Nit: Can you change the PR title to “Revert: Use ...” before merging?

@dconeybe dconeybe changed the title Revert Use crypo RNG for auto ID generation to reduce conflicts Revert: Use crypo RNG for auto ID generation to reduce conflicts Apr 6, 2020
@dconeybe dconeybe merged commit 7766278 into master Apr 6, 2020
@dconeybe
Copy link
Contributor Author

dconeybe commented Apr 6, 2020

Shoot... I forgot to update the change log. I'll do that in a separate PR.

@dconeybe dconeybe deleted the dconeybe/RevertCrypto branch April 6, 2020 18:35
@dconeybe dconeybe mentioned this pull request Apr 6, 2020
Merged
wu-hui added a commit that referenced this pull request May 4, 2020
@wu-hui
Reland "Use crypo RNG for auto ID generation to reduce conflicts (#2872…
867417c 
…)"
wu-hui added a commit that referenced this pull request May 4, 2020
@wu-hui
Reland "Use crypo RNG for auto ID generation to reduce conflicts (#2872…
a2b89c2 
…)"
@firebase firebase locked and limited conversation to collaborators May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

@wu-hui wu-hui Awaiting requested review from wu-hui

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

Assignees

@wilhuff wilhuff

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dconeybe @google-oss-bot @schmidt-sebastian @wilhuff