Fix IE11 broken by Crypto change. #2832
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feiyang1
reviewed
Mar 30, 2020
| @@ -75,6 +75,8 @@ export class BrowserPlatform implements Platform { | |||
| } | |||
|
|
|||
| const v = new Uint8Array(nBytes); | |||
| // Polyfill for IE11. | |||
| const crypto = window.crypto || (window as any).msCrypto; | |||
There was a problem hiding this comment.
You probably need to suppress eslint here to pass tests.
There was a problem hiding this comment.
It seems like you could do this once at the top of the file (after imports before the class).
Binary Size ReportAffected SDKs
Test Logs |
wilhuff
approved these changes
Mar 30, 2020
| @@ -75,6 +75,8 @@ export class BrowserPlatform implements Platform { | |||
| } | |||
|
|
|||
| const v = new Uint8Array(nBytes); | |||
| // Polyfill for IE11. | |||
| const crypto = window.crypto || (window as any).msCrypto; | |||
There was a problem hiding this comment.
It seems like you could do this once at the top of the file (after imports before the class).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2827