Skip to content

Call PlatformSupport.setPlatform() in generate_spec_json.js #2833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2020
Merged

Call PlatformSupport.setPlatform() in generate_spec_json.js #2833

merged 2 commits into from
Mar 30, 2020

Conversation

dconeybe
Copy link
Contributor

This fixes the following error when generate_spec_json.js is run:

Error: FIRESTORE (7.11.0) INTERNAL ASSERTION FAILED: Platform not set

This error was introduced by cae46453 a few days ago. The easy fix is to just set the platform in main().

dconeybe referenced this pull request Mar 30, 2020
@schmidt-sebastian
Field Value migration (#2784)
cae4645
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 30, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

SDKTypeBase (353f5ca)Head (bb2ad0d)Diff
Metric Unit: byte

Test Logs

@dconeybe dconeybe merged commit 1f16cdb into master Mar 30, 2020
@dconeybe dconeybe deleted the dconeybe/SetPlatformInGenerateSpecJson branch March 30, 2020 20:25
@firebase firebase locked and limited conversation to collaborators Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @schmidt-sebastian