Make Firestore-mangled build the only Firestore build #2640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
hsubox76
reviewed
Feb 18, 2020
packages/firestore/package.json
Outdated
| @@ -49,6 +46,7 @@ | |||
| "@firebase/app-types": "0.x" | |||
| }, | |||
| "devDependencies": { | |||
| "@types/node": "8.10.59", | |||
There was a problem hiding this comment.
This is in devDependencies in the root package.json, is there a reason to include it separately here?
There was a problem hiding this comment.
The paths in externs.json are relative to the package root, so I need this to be installed in packages/firestore/node_modules.
There was a problem hiding this comment.
Doesn't line 38 of firestore/rollup.config.js set them to be relative to repo root? The other files in externs.json seem to be relative to repo root.
There was a problem hiding this comment.
Yes! Updated.
hsubox76
approved these changes
Feb 18, 2020
|
@Feiyang1 Let me know if you have time to check whether this works properly with SourceMaps. |
|
@Feiyang1 confirmed the source maps still work as is. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
.min.jsfiles for Firestore and updates the default build to use the minified property names.It looks like the previous build did not include a mangled Node build - I added this here and because of that I also had to add externs for Node.