Skip to content

Commit 261bbd5

Browse files
Make Firestore-mangled build the only Firestore build (#2640)
1 parent 5512725 commit 261bbd5

File tree

6 files changed

+3
-75
lines changed

6 files changed

+3
-75
lines changed

integration/firestore/gulpfile.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ function copyTests() {
3737
const firebaseAppSdk = 'firebase/app/dist/index.esm.js';
3838
const firebaseFirestoreSdk = resolve(
3939
__dirname,
40-
'../../packages/firestore/dist/index.esm.min.js'
40+
'../../packages/firestore/dist/index.esm.js'
4141
);
4242
return gulp
4343
.src(

packages/firebase/firestore/index.min.ts

Lines changed: 0 additions & 18 deletions
This file was deleted.

packages/firebase/rollup.config.js

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -147,13 +147,6 @@ const componentBuilds = pkg.components
147147
})
148148
.reduce((a, b) => a.concat(b), []);
149149

150-
const firestoreMinifiedBuild = {
151-
input: `firestore/index.min.ts`,
152-
output: createUmdOutputConfig(`firebase-firestore.min.js`),
153-
plugins: [...plugins, uglify()],
154-
external: ['@firebase/app']
155-
};
156-
157150
/**
158151
* Complete Package Builds
159152
*/
@@ -267,9 +260,4 @@ const completeBuilds = [
267260
}
268261
];
269262

270-
export default [
271-
...appBuilds,
272-
...componentBuilds,
273-
firestoreMinifiedBuild,
274-
...completeBuilds
275-
];
263+
export default [...appBuilds, ...componentBuilds, ...completeBuilds];

packages/firestore/externs.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
{
22
"externs" : [
3+
"node_modules/@types/node/base.d.ts",
34
"node_modules/typescript/lib/lib.es5.d.ts",
45
"node_modules/typescript/lib/lib.dom.d.ts",
56
"node_modules/typescript/lib/lib.es2015.promise.d.ts",

packages/firestore/package.json

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,8 @@
2525
},
2626
"main": "dist/index.node.cjs.js",
2727
"browser": "dist/index.cjs.js",
28-
"browserMinified": "dist/index.cjs.min.js",
2928
"module": "dist/index.esm.js",
30-
"moduleMinified": "dist/index.esm.min.js",
3129
"esm2017": "dist/index.esm2017.js",
32-
"esm2017Minified": "dist/index.esm2017.min.js",
3330
"license": "Apache-2.0",
3431
"files": [
3532
"dist"

packages/firestore/rollup.config.js

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -64,14 +64,6 @@ const terserOptions = {
6464
* ES5 Builds
6565
*/
6666
const es5BuildPlugins = [
67-
typescriptPlugin({
68-
typescript,
69-
cacheRoot: './.cache/es5/'
70-
}),
71-
json()
72-
];
73-
74-
const es5MinifiedBuildPlugins = [
7567
typescriptPlugin({
7668
typescript,
7769
transformers,
@@ -114,35 +106,13 @@ const es5Builds = [
114106
],
115107
plugins: es5BuildPlugins,
116108
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
117-
},
118-
{
119-
input: 'index.ts',
120-
output: [
121-
{ file: pkg.browserMinified, format: 'cjs', sourcemap: true },
122-
{ file: pkg.moduleMinified, format: 'es', sourcemap: true }
123-
],
124-
plugins: es5MinifiedBuildPlugins,
125-
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
126109
}
127110
];
128111

129112
/**
130113
* ES2017 Builds
131114
*/
132115
const es2017BuildPlugins = [
133-
typescriptPlugin({
134-
typescript,
135-
tsconfigOverride: {
136-
compilerOptions: {
137-
target: 'es2017'
138-
}
139-
},
140-
cacheRoot: './.cache/es2017/'
141-
}),
142-
json({ preferConst: true })
143-
];
144-
145-
const es2017MinifiedBuildPlugins = [
146116
typescriptPlugin({
147117
typescript,
148118
tsconfigOverride: {
@@ -170,16 +140,6 @@ const es2017Builds = [
170140
},
171141
plugins: es2017BuildPlugins,
172142
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
173-
},
174-
{
175-
input: 'index.ts',
176-
output: {
177-
file: pkg.esm2017Minified,
178-
format: 'es',
179-
sourcemap: true
180-
},
181-
plugins: es2017MinifiedBuildPlugins,
182-
external: id => deps.some(dep => id === dep || id.startsWith(`${dep}/`))
183143
}
184144
];
185145

0 commit comments

Comments
 (0)