Skip to content

Check for process.env in isMockPersistence #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 6, 2019
Merged

Check for process.env in isMockPersistence #2407

merged 3 commits into from
Dec 6, 2019

Conversation

thebrianchen
Copy link

Fixes #2404.

In this particular instance, the user's process variable was defined, but process.env was not defined, which triggered an error when checking for process.env.USE_MOCK_PERSISTENCE.

@thebrianchen thebrianchen merged commit 878f577 into master Dec 6, 2019
@thebrianchen thebrianchen deleted the bc/mock-persist branch December 6, 2019 00:44
@hsubox76 hsubox76 added this to the next milestone Dec 10, 2019
@firebase firebase locked and limited conversation to collaborators Jan 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Assignees

@schmidt-sebastian schmidt-sebastian

Labels
api: firestore
Projects
None yet
Milestone
7.6.0
Development

Successfully merging this pull request may close these issues.

Firestore enablePersistence(): “Error enabling offline persistence. Falling back to persistence disabled”
3 participants
@thebrianchen @schmidt-sebastian @hsubox76