Check for process.env in isMockPersistence (#2407)

Brian Chen · web-flow · commit 878f577fe40a · 2019-12-05T16:44:05.000-08:00
diff --git a/packages/firestore/src/local/simple_db.ts b/packages/firestore/src/local/simple_db.ts
@@ -209,7 +209,7 @@ export class SimpleDb {
   static isMockPersistence(): boolean {
     return (
       typeof process !== 'undefined' &&
-      process.env.USE_MOCK_PERSISTENCE === 'YES'
+      process.env?.USE_MOCK_PERSISTENCE === 'YES'
     );
   }
 
diff --git a/packages/firestore/test/util/test_platform.ts b/packages/firestore/test/util/test_platform.ts
@@ -45,7 +45,8 @@ export class FakeWindow {
     });
     this.fakeIndexedDb =
       fakeIndexedDb ||
-      (typeof window !== 'undefined' && window.indexedDB) || null;
+      (typeof window !== 'undefined' && window.indexedDB) ||
+      null;
   }
 
   get localStorage(): Storage {

Original file line number	Diff line number	Diff line change
`@@ -209,7 +209,7 @@ export class SimpleDb {`
`209`	`209`	`static isMockPersistence(): boolean {`
`210`	`210`	`return (`
`211`	`211`	`typeof process !== 'undefined' &&`
`212`		`- process.env.USE_MOCK_PERSISTENCE === 'YES'`
	`212`	`+ process.env?.USE_MOCK_PERSISTENCE === 'YES'`
`213`	`213`	`);`
`214`	`214`	`}`
`215`	`215`
Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,8 @@ export class FakeWindow {`
`45`	`45`	`});`
`46`	`46`	`this.fakeIndexedDb =`
`47`	`47`	`fakeIndexedDb \|\|`
`48`		`- (typeof window !== 'undefined' && window.indexedDB) \|\| null;`
	`48`	`+ (typeof window !== 'undefined' && window.indexedDB) \|\|`
	`49`	`+ null;`
`49`	`50`	`}`
`50`	`51`
`51`	`52`	`get localStorage(): Storage {`