Adding documentation for WriteBatch size limit #1715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebrianchen
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
mikelehen
suggested changes
Apr 23, 2019
|
Oh wow, that is a subtlety that is hard to glean from just skimming the documentation. Thanks for pointing it out and explaining it to me! |
mikelehen
approved these changes
Apr 23, 2019
| @@ -206,8 +212,14 @@ export class FirebaseFirestore { | |||
| ): Promise<T>; | |||
|
|
|||
| /** | |||
| * Creates a write batch, used for performing multiple writes as a single | |||
| * atomic operation. | |||
| * Creates a write batch, used for performing multiple writes as a single | |||
There was a problem hiding this comment.
Oooh, thanks for bringing this into sync.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: b/70222712