Skip to content

Adding documentation for WriteBatch size limit #392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 30, 2019
Merged

Adding documentation for WriteBatch size limit #392

merged 2 commits into from
Apr 30, 2019

Conversation

thebrianchen
Copy link

context: b/70222712

Web SDK change: firebase/firebase-js-sdk#1715

@googlebot googlebot added the cla: yes Override cla label Apr 30, 2019
@thebrianchen thebrianchen requested a review from mikelehen April 30, 2019 21:12
mikelehen
mikelehen approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@mikelehen mikelehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a tad too much copy/pasta, but otherwise LGTM.

@mikelehen mikelehen assigned thebrianchen and unassigned mikelehen Apr 30, 2019
@thebrianchen thebrianchen merged commit 4e40319 into master Apr 30, 2019
@thebrianchen thebrianchen deleted the bc/500docu branch April 30, 2019 22:31
@firebase firebase locked and limited conversation to collaborators Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikelehen mikelehen mikelehen approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thebrianchen @mikelehen @googlebot @google-oss-bot