Skip to content

update documentation to show the correct import syntax #1274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 18, 2018
Merged

update documentation to show the correct import syntax #1274

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4c3c14c
update documentation to show the correct import syntax
Feiyang1 Oct 2, 2018
4d7d8d0
update import syntax for firebase/app
Feiyang1 Oct 2, 2018
f85c880
add example for native es6 module in node
Feiyang1 Oct 2, 2018
232062e
update warning message to use the correct syntax for typescript
Feiyang1 Oct 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/firebase/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ var app = firebase.initializeApp({ ... });
If you are using ES6 imports or TypeScript:

```
import firebase from 'firebase';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's another instance (import firebase from 'firebase/app') that should be updated too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! done.

import * as firebase from 'firebase';
var app = firebase.initializeApp({ ... });
```

Expand Down