update documentation to show the correct import syntax

[Feiyang1]

import firebase from 'firebase'

doesn't work with the typings we currently have. It works with vanilla javascript though. But to keep it consistently across javascript and typescript, I'm updating it to

import * as firebase from 'firebase'

[mikelehen]

I think there's another instance (import firebase from 'firebase/app') that should be updated too?

[Feiyang1]

good catch! done.

[mikelehen]

Cool, LGTM.

[mikelehen]

Oh, hrm. Based on #1206 (comment) I guess this change isn't entirely a slam dunk (it'll break people targeting node)? I'm guessing it's still an improvement (I suspect browser usage is much more common), but maybe @jamesdaniels will want to weigh in on what we should be documenting here. Maybe we should describe both syntaxes and when to use each or something.

[Feiyang1]

Good point. It's a problem when people tries to use native es6 module in node. Native es6 module support in node is still experimental and is hidden behind a flag, so it's probably a rare use case. Anyway, I only updated the section for browser use cases, and in node use case, we only advise to use require() syntax, so we are not misleading people hopefully.
I don't think we need to, but I added a section to explain the native es6 module use case in node. @mikelehen, @jamesdaniels if you think it adds confusion, I will remove it.

[mikelehen]

I'll let James weigh in as he's much more familiar with the nuances here. 😁

[Feiyang1]

@jamesdaniels Are you okay with the change?

[jamesdaniels]

LGTM.

Sorry I've not had the time to dig in a bit more here. This seems to be the most consistent for the moment.