Skip to content

Add priming logic to integration tests to avoid backend cold start issues. #1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 51 additions & 0 deletions packages/firestore/test/integration/prime_backend.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
/**
* Copyright 2018 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

import * as firestore from '@firebase/firestore-types';
import { expect } from 'chai';
import { EventsAccumulator } from './util/events_accumulator';
import { withTestDoc } from './util/helpers';

// Firestore databases can be subject to a ~30s "cold start" delay if they have not been used
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line length?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Last week I added tslint enforcement of 100 (
    "max-line-length": [true, {"limit": 100, "ignore-pattern": "https?://"}],
    ), so I'm leaving this as is unless you care strongly about changing it.

// recently, so before any tests run we "prime" the backend.

const PRIMING_TIMEOUT_MS = 45000;

before(
'Prime backend by waiting for a write to show up in the watch stream',
function(): Promise<void> {
this.timeout(PRIMING_TIMEOUT_MS);

return withTestDoc(/*persistence=*/ false, async doc => {
const accumulator = new EventsAccumulator<firestore.DocumentSnapshot>();
const unsubscribe = doc.onSnapshot(accumulator.storeEvent);

// Wait for watch to initialize and deliver first event.
await accumulator.awaitRemoteEvent();

// Use a transaction to perform a write without triggering any local events.
await doc.firestore.runTransaction(async txn => {
txn.set(doc, { value: 'done' });
});

// Wait to see the write on the watch stream.
const docSnap = await accumulator.awaitRemoteEvent();
expect(docSnap.get('value')).to.equal('done');

unsubscribe();
});
}
);