Add priming logic to integration tests to avoid backend cold start issues. #1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikelehen
requested review from
gsoltis,
rsgowman,
schmidt-sebastian,
var-const and
zxu123
as code owners
mikelehen
pushed a commit
to firebase/firebase-android-sdk
that referenced
this pull request
Sep 28, 2018
wilhuff
reviewed
Sep 28, 2018
| import { EventsAccumulator } from './util/events_accumulator'; | ||
| import { withTestDoc } from './util/helpers'; | ||
|
|
||
| // Firestore databases can be subject to a ~30s "cold start" delay if they have not been used |
There was a problem hiding this comment.
- Last week I added tslint enforcement of 100 ( ), so I'm leaving this as is unless you care strongly about changing it.
|
Yeah, A before() block outside the context of a describe() will run before all tests in all suites. |
|
Doesn't this mean we start a listener and do a transaction for every test then? It seems like if all we care about is "priming" then we should be able to run this once. Alternatively if test run times before and after are comparable then I guess it doesn't matter, but intuitively this seems like it could add up. |
|
Sorry, I was trying to describe when it runs, not how often... It'll only run once, regardless of how many tests are running. |
mikelehen
pushed a commit
to firebase/firebase-ios-sdk
that referenced
this pull request
Sep 28, 2018
…sues. Port of firebase/firebase-js-sdk#1259 except I didn't use EventAccumulator since it hits the default timeout. I just manually do the listener.
mikelehen
added a commit
to firebase/firebase-ios-sdk
that referenced
this pull request
Oct 2, 2018
…sues. (#1890) Port of firebase/firebase-js-sdk#1259 except I didn't use EventAccumulator since it hits the default timeout. I just manually do the listener.
mikelehen
added a commit
to firebase/firebase-android-sdk
that referenced
this pull request
Oct 3, 2018
…sues. (#50) Port of firebase/firebase-js-sdk#1259 except reworked to use listener since EventAccumulator doesn't accept arbitrary timeouts.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.